Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade react-measure to version 2.x #2792

Closed
brent-hoover opened this issue Sep 5, 2017 · 3 comments
Closed

Upgrade react-measure to version 2.x #2792

brent-hoover opened this issue Sep 5, 2017 · 3 comments
Labels
chore For issues that describe a task that does not affect the release, such as tests or CI configuration

Comments

@brent-hoover
Copy link
Collaborator

Bithound is showing this as an outdated dependency and I tested just straight upgrading it and it does break the MediaGallery (the one file it's currently used in).

It's probably not a big task to adapt to the new API but it should probably be done soon.

@brent-hoover brent-hoover added the chore For issues that describe a task that does not affect the release, such as tests or CI configuration label Sep 5, 2017
@kieckhafer
Copy link
Member

It's a little more complicated than just following their docs. @jshimko pointed out the issue in #2592 , we can't just wrap their new ref prop, like they mention in their docs... we'd actually have to rewrite the way our MediaGallery works. We currently use a react component, MediaItem, inside the gallery, and react-measure doesn't allow a nested react component, it only works on straight DOM elements.

@janus-reith mentioned a replacement for MediaGallery in the above mentioned issue... replacing MediaGallery is something we've discussed before, if we are moving forward with looking into a replacement, its probably best to hold off on updating react-measure until then, I don't know if it's worth rewriting the current media gallery just to work with react-measure 2.0

@brent-hoover
Copy link
Collaborator Author

Whoops. Should have searched before creating this issue. It's a dupe. Closing.

@janus-reith
Copy link
Collaborator

@kieckhafer I answered in #2592

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore For issues that describe a task that does not affect the release, such as tests or CI configuration
Projects
None yet
Development

No branches or pull requests

3 participants