Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Products sub not updating component reactively #3146

Closed
joykare opened this issue Oct 20, 2017 · 3 comments
Closed

Products sub not updating component reactively #3146

joykare opened this issue Oct 20, 2017 · 3 comments
Labels
bug For issues that describe a defect or regression in the released software

Comments

@joykare
Copy link
Contributor

joykare commented Oct 20, 2017

Expected behavior

When you disable a shop, products of said shop should be hidden from view without having to refresh.
The products sub is not being re-called on the component till a refresh is done.

Actual behavior

You have to refresh for the products to be filtered out.

Steps to reproduce the behavior

@joykare joykare mentioned this issue Oct 20, 2017
@brent-hoover brent-hoover added the bug For issues that describe a defect or regression in the released software label Oct 23, 2017
@codejockie
Copy link
Contributor

@joykare could you please clarify on this issue, I've tried reproducing the issue but I'm unable to do that. The link you provided is dead.

@joykare
Copy link
Contributor Author

joykare commented Nov 3, 2017

@codejockie replaced the link on the description. If you remove that snippet every time you disable a shop you need to refresh the page for changes to occur.

  • We need to have the subscription run continuously coz we want the changes to be reactive. What is happening now is that the subscription runs only once(when the component is rendered).

More context on this:
The products are already filtered out in the back-end to display only when a shop is active
https://github.com/reactioncommerce/reaction/blob/master/server/publications/collections/products.js#L98
So we just need the front end to have the updated list of products all the time

@codejockie codejockie removed their assignment Nov 10, 2017
@spencern spencern added this to the Bugfix Sprint 1 milestone Feb 9, 2018
@spencern spencern removed this from the Bugfix Sprint 1 milestone Feb 20, 2018
@aldeed
Copy link
Contributor

aldeed commented Jul 11, 2019

No longer an issue in 2.0.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug For issues that describe a defect or regression in the released software
Projects
None yet
Development

No branches or pull requests

5 participants