Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Audit all MethodHooks.after and ensure we are returning options.result #3583

Closed
brent-hoover opened this issue Jan 25, 2018 · 1 comment
Closed

Audit all MethodHooks.after and ensure we are returning options.result #3583

brent-hoover opened this issue Jan 25, 2018 · 1 comment
Labels
chore For issues that describe a task that does not affect the release, such as tests or CI configuration

Comments

@brent-hoover
Copy link
Collaborator

In some places this is just returning options, which for an after hook, is incorrect.
@brent-hoover brent-hoover added the chore For issues that describe a task that does not affect the release, such as tests or CI configuration label Jan 25, 2018
@brent-hoover brent-hoover self-assigned this Jan 25, 2018
@brent-hoover brent-hoover mentioned this issue Jan 25, 2018
Merged
@brent-hoover brent-hoover removed their assignment Jan 29, 2018
@machikoyasuda
Copy link
Contributor

Can we close this? Method hooks are removed #4915

@aldeed aldeed closed this as completed Jul 11, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
chore For issues that describe a task that does not affect the release, such as tests or CI configuration
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@brent-hoover @aldeed @machikoyasuda