-
Notifications
You must be signed in to change notification settings - Fork 2.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Unable to update shop name, Promise.await is not a function #4202
Comments
I'm experiencing the same problem when trying to change e.g. timezone in localization/i18n settings. |
Same Problem. Fresh install on linux mint using the reaction-cli and I can't update the store name without receiving the |
Hi, I have same problem. I create new reaction project on fresh linux mint and I can't update store and localisation settings. |
Same issue here. I have a client's multi-vendor marketplace which can't onboard new users due to that issue. As you can imagine, that's pretty critical. Is there a quick fix one can apply while waiting for the official patch? |
@loanlaux One thing you could try for a temporary fix is to remove the dynamic import for the slugify / transliteration packages in the |
Thanks @nnnnat, I did exactly this and will stand by until it's officially fixed! |
Hello, the same problem is occurring for me. Note: I have two RC applications. These problems only occur in the application that I installed the REST API (simple: rest) and I created a new container in development environment, and pulled into production. In the application I installed directly without creating a new container, it's working Thank you. |
@loanlaux didn't work for us so far. Any other solutions? |
I am on the latest 1.12.0 and still cannot change shop name, from the admin |
Same here, nothing's change in new version... |
I'm closing this as this is fixed in |
Prerequisites
Issue Description
TypeError: Promise.await is not a function
in browser console when saving updated shop name. I believe this same issue is effecting the product handle and possibly other fields in the UI.Steps to Reproduce
Possible Solution
I think this might be a regression from PR#4049.
Trying to lazy load the slugify/transliteration has been really tricky mainly because there are 3 versions of the same
getSlug
helper method. One that only runs on the server, one that only runs on the client and another that tries to run in both. It also seems that different parts of the UI use the differentgetSLug
methods (tag nav is usinggetSlug
from theclient
dir while shop name use thegetSlug
method inside of thelib
dir).I feel like there are two main issues to tackle
getSlug
method that:getSlug
usage:getSlug
method inside oflib
that can be used by both server and client.lib
version.Versions
The text was updated successfully, but these errors were encountered: