Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

calculateOrderTaxes triggered indefinitely #4995

Closed
Akarshit opened this issue Feb 18, 2019 · 2 comments
Closed

calculateOrderTaxes triggered indefinitely #4995

Akarshit opened this issue Feb 18, 2019 · 2 comments
Assignees
@aldeed
Milestone
🏔 Torreys

Comments

@Akarshit
Copy link
Contributor

The methods to calculate taxes are triggered indefinitely.

Add a console.log("Calculating taxes");
here: imports/plugins/included/taxes-rates/server/no-meteor/util/calculateOrderTaxes.js, line 48.

Go to the checkout page, select shipping methods. Look in the server console. You will see the message "Calculating taxes" print indefinitely.
@aldeed aldeed self-assigned this Feb 19, 2019
@aldeed aldeed added this to the 🏔 Torreys milestone Feb 19, 2019
@aldeed
Copy link
Contributor

aldeed commented Feb 19, 2019

I can reproduce this on develop

@aldeed
Copy link
Contributor

aldeed commented Feb 20, 2019

This is due to unnecessary afterCartUpdate emits from the surcharges plugin. I'll have a fix PR soon.

@aldeed aldeed mentioned this issue Feb 20, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@aldeed aldeed

Labels
None yet
Projects
None yet
Milestone
🏔 Torreys
Development

No branches or pull requests
2 participants
@aldeed @Akarshit