Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move inventory data out of Product and into it's own collection #5107

Closed
brent-hoover opened this issue Apr 8, 2019 · 4 comments
Closed
Assignees

Comments

@brent-hoover
Copy link
Collaborator

Having inventory on product causes problems for trying to update it as it requires that an entire product be published just to update inventory.

It should be its own standalone collection

@spencern
Copy link
Contributor

spencern commented Apr 8, 2019

I agree that we should separate Inventory from Product (which contains mostly product information data). I think doing this is a significant change that should allocate time for designing the architecture and understanding the current and future requirements we'll have for inventory systems.

@ticean
Copy link
Member

ticean commented Apr 8, 2019

I would love to see this happen ASAP! Product the product collection runs hot. Inventory is a frequently changing field and doesn't need to be entangled with the entire product record.

@brent-hoover
Copy link
Collaborator Author

I think moving the data from being on the product to being in it's own collection is a good first step that doesn't block any implementations in the future and would be a relatively simple change with a big gain in server load. GraphQL resolvers really free us up here...

@loan-laux
Copy link
Collaborator

Not only should it be in its own collection, but inventory figures should be returned by their own plugin IMO. Just like it's done with simple-pricing, allowing anyone to skip Reaction's inventory management and fetch that data from an ERP.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants