-
Notifications
You must be signed in to change notification settings - Fork 2.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
PDP Package.layout implementation #517
Milestone
Comments
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
The goal of this feature is to allow repositioning (layout) of functional blocks on the PDP page, as well as the addition, removal and permission based viewing of blocks as necessary.
We'll need to refactor the Product Detail Page to use
ReactionTemplates
, usingPackages.layout
entries to define different product types and associate layout and templates with the PDP based on the product'sProduct.type
entry.This will make the PDP less rigid, and makes implementation much simpler for #152, #343, #330, #191, #368, #367, #443, #500, #516 , #225.
ProductDetail.html will become a layout loader page, essentially just:
and we add a new
layout
entry inregister.js
for thesimple
PDP layout:assuming
type
=simple
, and where we've created a new product layout template:the individual blocks get moved into their own templates:
The
register.js
will get a newlayout
entry for each PDP template:The text was updated successfully, but these errors were encountered: