Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename "optionTitle" to something more clear as to what it's purpose is #5206

Closed
brent-hoover opened this issue Jun 10, 2019 · 1 comment
Closed

Rename "optionTitle" to something more clear as to what it's purpose is #5206

brent-hoover opened this issue Jun 10, 2019 · 1 comment

Comments

@brent-hoover
Copy link
Collaborator

I can't tell you how much time has been wasted and confusion caused because this field is poorly named. I don't know why it wasn't called cartTitle or shortTitle or something more clear in the first place but here we are.
@brent-hoover brent-hoover changed the title Rename optionTitle to cartTitle like it should have been called Rename "optionTitle" to "cartTitle" like it should have been called Jun 10, 2019
@aldeed
Copy link
Contributor

aldeed commented Jun 11, 2019

I don't know that cartTitle is 100% accurate either (the title becomes the cart item title), but shortTitle makes sense to me.

Related, in CartItem, I think it would make more sense if:

  • title -> productTitle
  • optionTitle deprecate it because it's in attributes

@aldeed aldeed mentioned this issue Jun 11, 2019
Closed
@brent-hoover brent-hoover changed the title Rename "optionTitle" to "cartTitle" like it should have been called Rename "optionTitle" to something more clear as to what it's purpose is Jun 12, 2019
@aldeed aldeed mentioned this issue Jun 30, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@delagroove @brent-hoover @aldeed