absoluteUrl test failing randomly

[mikemurray]

Issue Description

The absoluteUrl.app-test.js test "uses the current connection's host" seems to fail sometimes because of a timeout... or something.

reaction/imports/plugins/core/core/server/Reaction/absoluteUrl.app-test.js

Lines 61 to 63 in d4177ca

	it("uses the current connection's host", () => {
	expect(core.absoluteUrl()).to.include(connectionHost);
	});

I20190628-16:50:04.592(0)? 
I20190628-16:50:04.592(0)?   AbsoluteUrlMixin
I20190628-16:50:04.592(0)?     #absoluteUrl
      ✓ accepts options the same way composeUrl does
I20190628-16:50:04.593(0)?       outside of a connection
        ✓ defaults to $ROOT_URL
I20190628-16:50:04.594(0)?       within a connection
        1) "before each" hook: wrappedFunction for "uses the current connection's host"
I20190628-16:50:06.745(0)? 16:50:06.745Z  INFO Reaction: Reaction Version: 2.0.0-rc.10
I20190628-16:50:06.754(0)? 16:50:06.754Z  INFO Reaction: JobServer started
I20190628-16:50:06.765(0)? 
I20190628-16:50:06.765(0)?   ConnectionDataStore
I20190628-16:50:06.765(0)?     used outside of a connection
      ✓ sets/gets cached data
      ✓ clears cached data
I20190628-16:50:06.770(0)?     within the context of a connection
      ✓ sets/gets cached data
      ✓ stores data on the connection object
I20190628-16:50:06.797(0)?     within the context of a multiple connections
      ✓ does not access previous connection's data
      ✓ does not modify previous connection's data
      ✓ does modify _this_ connection's data
I20190628-16:50:06.804(0)? 
I20190628-16:50:06.804(0)? 
I20190628-16:50:06.804(0)?   22 passing (2s)
I20190628-16:50:06.804(0)?   1 failing
I20190628-16:50:06.804(0)? 
I20190628-16:50:06.805(0)?   1) AbsoluteUrlMixin #absoluteUrl within a connection "before each" hook: wrappedFunction for "uses the current connection's host":
I20190628-16:50:06.805(0)?      Error: timeout of 2000ms exceeded. Ensure the done() callback is being called in this test.
I20190628-16:50:06.805(0)?       at run (packages/practicalmeteor:mocha-core/server.js:52:15)
I20190628-16:50:06.805(0)? 
I20190628-16:50:06.805(0)? 
I20190628-16:50:06.805(0)? 
I20190628-16:50:06.805(0)? SKIPPING CLIENT TESTS BECAUSE TEST_CLIENT=0

Steps to Reproduce

1. Run tests on CI (dunno if it happens locally)
2. Sometimes randomly fails.
3. Re-running tests, a few times and it will pass eventually.

Possible Solution

• Ensure the test, if it's async, that things are properly awaited
• Increase the timeout? "when in doubt, setTimeout"

[kieckhafer]

Resolved via #5317