Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ESLINT] audit rule: valid-jsdoc #5267

Closed
kieckhafer opened this issue Jul 3, 2019 · 0 comments
Closed

[ESLINT] audit rule: valid-jsdoc #5267

kieckhafer opened this issue Jul 3, 2019 · 0 comments

Comments

@kieckhafer
Copy link
Member

kieckhafer commented Jul 3, 2019 •
edited
Loading

We have multiple eslint warnings for the valid-jsdoc rule.

This ticket is to:

  1. Fix all these eslint warnings. This SHOULD mean actually fixing them, but could also mean adding an eslint-disable-line, if applicable.
  2. Remove the warn override of this rule in our package.json, so the error rule from https://github.com/reactioncommerce/reaction-eslint-config takes effect.

Look into switching to their new plugin: https://eslint.org/blog/2018/11/jsdoc-end-of-life
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@kieckhafer