Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

i18n Selected language doesn't save. Always reset to english after F5 #890

Closed
ramusus opened this issue Mar 9, 2016 · 1 comment
Closed

i18n Selected language doesn't save. Always reset to english after F5 #890

ramusus opened this issue Mar 9, 2016 · 1 comment
Assignees
@aaronjudd
Milestone
v0.16.0

Comments

@ramusus
Copy link
Contributor

ramusus commented Mar 9, 2016 •
edited by aaronjudd
Loading

If i'm not mistaken saving selected language was already implemented, but now it doesn't works.
Tested in Safari
@ramusus ramusus changed the title i18n Selected language doesn't save. Always reset to 'en' after F5 i18n Selected language doesn't save. Always reset to english after F5 Mar 9, 2016
@aaronjudd aaronjudd added this to the v0.12.0 milestone Mar 11, 2016
@aaronjudd aaronjudd added the bug label Mar 11, 2016
@aaronjudd aaronjudd self-assigned this Mar 11, 2016
@aaronjudd aaronjudd modified the milestones: v0.13.0, v0.12.0 Mar 15, 2016
@aaronjudd aaronjudd added backlog and removed ready labels Mar 15, 2016
@nialexsan
Copy link
Contributor

nialexsan commented Apr 16, 2016 •
edited
Loading

Language is set in Session.language in packages/reaction-i18n/client/templates/header/i18n.js:37.
As I know in Meteor every time reloading the page you reset this scope.

@brent-hoover brent-hoover removed the bug label May 17, 2016
@brent-hoover brent-hoover modified the milestones: v0.14.0, v0.13.0 May 17, 2016
@aaronjudd aaronjudd modified the milestones: v0.15.0 RC, v0.14.0 Jun 28, 2016
@aaronjudd aaronjudd modified the milestones: v0.15.0, v0.16.0 Aug 18, 2016
@aaronjudd aaronjudd mentioned this issue Aug 31, 2016
Merged
@ghost ghost removed the review label Sep 21, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@aaronjudd aaronjudd

Labels
None yet
Projects
None yet
Milestone
v0.16.0
Development

No branches or pull requests
4 participants
@brent-hoover @ramusus @aaronjudd @nialexsan