Skip to content

Commit

Permalink
fix(closure): Annotate next() for ReplaySubject (#5088)
Browse files Browse the repository at this point in the history
Closure thinks `next()` is `UnusableType` instead of `(value: T) => void`, adding an `@override` annotation when overriding the method fixes this issue
  • Loading branch information
kolodny authored and benlesh committed Nov 11, 2019
1 parent ec77f3f commit 8687fbd
Showing 1 changed file with 1 addition and 0 deletions.
1 change: 1 addition & 0 deletions src/internal/ReplaySubject.ts
Original file line number Diff line number Diff line change
Expand Up @@ -28,6 +28,7 @@ export class ReplaySubject<T> extends Subject<T> {

if (windowTime === Number.POSITIVE_INFINITY) {
this._infiniteTimeWindow = true;
/** @override */
this.next = this.nextInfiniteTimeWindow;
} else {
this.next = this.nextTimeWindow;
Expand Down

0 comments on commit 8687fbd

Please sign in to comment.