Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(docs): fix code examples #3784

Merged
merged 1 commit into from
Jun 4, 2018

Conversation

niklas-wortmann
Copy link
Member

Dgeni is actually not capable to transform @example jsdoc notation. For this purpose I changed all examples to the md notation. For results see attached images. The only exception is generate.ts. the function overloading makes the example looks kinda weird. Will make a seperate pull request for generate.ts

windowwhen_before
windowwhen_after

@rxjs-bot
Copy link

rxjs-bot commented Jun 4, 2018

Warnings
⚠️

❗ Big PR (1)

(1) : Pull Request size seems relatively large. If Pull Request contains multiple changes, split each into separate PR will helps faster, easier review.

Generated by 🚫 dangerJS

@benlesh
Copy link
Member

benlesh commented Jun 4, 2018

Awesome! Thanks @jwo719

@benlesh benlesh merged commit a95441b into ReactiveX:master Jun 4, 2018
@lock lock bot locked as resolved and limited conversation to collaborators Jul 4, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants