Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Errors when RxJS 6.3 and 6.2 exist in the same node project. #4077

Closed
benlesh opened this issue Aug 31, 2018 · 0 comments · Fixed by #4078
Closed

Errors when RxJS 6.3 and 6.2 exist in the same node project. #4077

benlesh opened this issue Aug 31, 2018 · 0 comments · Fixed by #4078
Assignees
@benlesh

Comments

@benlesh
Copy link
Member

benlesh commented Aug 31, 2018

It's complaining because it passed the isTrustedSubscriber test when it shouldn't. There's a new _addParentTeardownLogic method that is required in 6.3
@benlesh benlesh self-assigned this Aug 31, 2018
benlesh added a commit to benlesh/rxjs that referenced this issue Aug 31, 2018
@benlesh
fix(node): will no longer error mixing RxJS 6.3 and 6.2
d68ea20 
- updates `isTrustedSubscriber` to check for `_addParentTeardownLogic`

resolves ReactiveX#4077
@benlesh benlesh mentioned this issue Aug 31, 2018
Merged
@alan-agius4 alan-agius4 mentioned this issue Sep 3, 2018
Closed
@cartant cartant mentioned this issue Sep 4, 2018
Closed
benlesh added a commit to benlesh/rxjs that referenced this issue Sep 4, 2018
@benlesh
fix(node): will no longer error mixing RxJS 6.3 and 6.2
111971b 
- updates `isTrustedSubscriber` to check for `_addParentTeardownLogic`

resolves ReactiveX#4077
benlesh added a commit that referenced this issue Sep 4, 2018
@benlesh
fix(node): will no longer error mixing RxJS 6.3 and 6.2 (#4078)
69d9ccf 
- updates `isTrustedSubscriber` to check for `_addParentTeardownLogic`

resolves #4077
@alan-agius4 alan-agius4 mentioned this issue Sep 13, 2018
Closed
@lock lock bot locked as resolved and limited conversation to collaborators Oct 4, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@benlesh benlesh

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(node): will no longer error mixing RxJS 6.3 and 6.2 benlesh/rxjs
1 participant
@benlesh