Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(node): will no longer error mixing RxJS 6.3 and 6.2 #4078

Merged
merged 1 commit into from
Sep 4, 2018
Merged

fix(node): will no longer error mixing RxJS 6.3 and 6.2 #4078

merged 1 commit into from
Sep 4, 2018

Conversation

benlesh
Copy link
Member

@benlesh benlesh commented Aug 31, 2018

  • updates isTrustedSubscriber to check for _addParentTeardownLogic

resolves #4077

@kwonoj
Copy link
Member

kwonoj commented Aug 31, 2018

we don't need check for both for prior version?

@benlesh
Copy link
Member Author

benlesh commented Aug 31, 2018

@kwonoj not really, if _addParentTeardownLogic is present, the other one will be there. Unless someone tries to write their own clever, forked version of RxJS and mix it with 6.3.

@kwonoj
Copy link
Member

kwonoj commented Aug 31, 2018

gotcha. Go for it 🚢

@alan-agius4 alan-agius4 mentioned this pull request Sep 3, 2018
Closed
@benlesh
fix(node): will no longer error mixing RxJS 6.3 and 6.2
111971b 
- updates `isTrustedSubscriber` to check for `_addParentTeardownLogic`

resolves ReactiveX#4077
@benlesh benlesh mentioned this pull request Sep 4, 2018
Closed
@coveralls
Copy link

Coverage Status

Coverage remained the same at 96.96% when pulling 111971b on benlesh:fix-hansl-stuffs into 4dde71b on ReactiveX:master.

@benlesh benlesh merged commit 69d9ccf into ReactiveX:master Sep 4, 2018
@benlesh benlesh mentioned this pull request Sep 4, 2018
Closed
@lock lock bot locked as resolved and limited conversation to collaborators Oct 4, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jayphelps jayphelps jayphelps approved these changes

@kwonoj kwonoj kwonoj approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Errors when RxJS 6.3 and 6.2 exist in the same node project.
4 participants
@benlesh @kwonoj @coveralls @jayphelps