fix(subscribe): don't swallow internal errors #4089
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
benlesh
requested changes
Sep 4, 2018
src/internal/util/reportError.ts
Outdated
| @@ -0,0 +1,34 @@ | |||
| import { Subscriber } from '../Subscriber'; | |||
There was a problem hiding this comment.
Since this is only used in one spot, you can just inline everything in that one spot. It'll perform better, and will be more readable (if a little harder to test)
There was a problem hiding this comment.
For tests, I'd rather just have more integration/functional tests of this.
src/internal/util/reportError.ts
Outdated
| return true; | ||
| } | ||
|
|
||
| function consoleReportError(err: any): void { |
There was a problem hiding this comment.
consoleWarn, this is too confusing considering we have a hostReportError function in the library, which is different.
|
@benlesh I've made a bunch of changes inline with your requests:
|
The build is failing✨ Good work on this PR so far! ✨ Unfortunately, the Travis CI build is failing as of 30440d2. Here's the output:
|
benlesh
requested changes
Sep 7, 2018
src/internal/util/canReportError.ts
Outdated
| const { closed, destination, isStopped } = observer as any; | ||
| if (closed || isStopped) { | ||
| return false; | ||
| } else if (destination instanceof Subscriber || (destination && destination[rxSubscriberSymbol])) { |
src/internal/util/canReportError.ts
Outdated
| * need to be reported via a different mechanism. | ||
| * @param observer the observer | ||
| */ | ||
| export function canReportError(observer: ErrorObserver<any>): boolean { |
There was a problem hiding this comment.
This should always be a Subscriber of some sort.
src/internal/util/consoleWarn.ts
Outdated
| @@ -0,0 +1,7 @@ | |||
| export function consoleWarn(...args: any[]): void { | |||
| if (console.warn) { | |||
There was a problem hiding this comment.
We shouldn't have to check this every time the function is called.
export const consoleWarn = console.warn ? console.warn.bind(console) : console.log.bind(console);
|
Looking good, just a couple of nits. |
|
@benlesh I've made changes inline with your requests:
However, I've not changed
I could replace it with: export const consoleWarn = console.warn ?
(...args: any[]) => console.warn(...args) :
(...args: any[]) => console.log(...args);But I cannot see that making a discernible difference. |
|
|
benlesh
approved these changes
Sep 12, 2018
|
which version of RxJs will this be included? |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
This PR reports errors that would otherwise be swallowed - because of a closed subscriber - to the console. (This behaviour is something that bit me again, today, when I was investigating a snippet that effected a stack overflow error in v5, but didn't effect the error in v6. The error was still occurring, of course, it just wasn't being thrown.)
As discussed in the linked issue, calling
hostReportErrorwould be preferred - rather than writing to the console - but doing so would be a breaking change.Related issue (if exists): #3803