perf(internal): optimize Subscription#add() for the common case #4489
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This removes unnecessary checks on the `teardown` parameter upfront, and instead moves these checks into the appropriate branches guarded by the type check. This way we get the same behavior, but with fewer checks and smaller code size. Also optimize adding the child `subscription` to `this._subscriptions` for the common case that there were no previous subscriptions.
bmeurer
force-pushed
the
Subscription_add_common
branch
from
af9b360
to
0b43a7a
Compare
bmeurer
commented
Jan 24, 2019
| @@ -168,13 +160,21 @@ export class Subscription implements SubscriptionLike { | |||
| subscription._subscriptions = [tmp]; | |||
| } | |||
| break; | |||
| default: | |||
| default: { | |||
| if (!(<any>teardown)) { | |||
There was a problem hiding this comment.
Is this just leftover defensive programming? Or is this on purpose?
Pull Request Test Coverage Report for Build 7942
💛 - Coveralls |
benlesh
approved these changes
Jan 24, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This removes unnecessary checks on the
teardownparameter upfront, andinstead moves these checks into the appropriate branches guarded by the
type check. This way we get the same behavior, but with fewer checks and
smaller code size.
Also optimize adding the child
subscriptiontothis._subscriptionsfor the common case that there were no previous subscriptions.