Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(index): export NotificationKind #4514

Merged
merged 1 commit into from
Jan 30, 2019
Merged

fix(index): export NotificationKind #4514

merged 1 commit into from
Jan 30, 2019

Conversation

cartant
Copy link
Collaborator

@cartant cartant commented Jan 30, 2019

Description:

Exports NotificationKind.

Related issue (if exists): #4513

@cartant
Copy link
Collaborator Author

cartant commented Jan 30, 2019 •
edited
Loading

I've had to update a dtslint spec to fix a CI breakage.

It seems that a version must have been updated somewhere, as one of the inferred unions is now in an unexpected order.

Hopefully, this is something that won't happen often. Otherwise, the tests will be pretty fragile.

Will have to look at this some other time.

@cartant cartant force-pushed the issue-4513 branch 2 times, most recently from 915a78d to 5248115 Compare January 30, 2019 21:17
@benlesh benlesh merged commit 7125355 into ReactiveX:master Jan 30, 2019
This was referenced Feb 7, 2019
Closed
Closed
@lock lock bot locked as resolved and limited conversation to collaborators Mar 1, 2019
@cartant cartant deleted the issue-4513 branch September 24, 2020 07:08
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@kwonoj kwonoj kwonoj approved these changes

@benlesh benlesh benlesh approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@cartant @kwonoj @benlesh