Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(race): better typings #4643

Merged
merged 1 commit into from
Mar 15, 2019
Merged

fix(race): better typings #4643

merged 1 commit into from
Mar 15, 2019

Conversation

benlesh
Copy link
Member

@benlesh benlesh commented Mar 15, 2019

  • Actually accept other ObservableInput types (Promises, etc)
  • Fixes issue where TypeScript would complain when you tried to subscribe to a race between to Observable types.

Fixes #4390
Fixes #4642

@benlesh
fix(race): better typings
a3630e1 
- Actually accept other `ObservableInput` types (Promises, etc)
- Fixes issue where TypeScript would complain when you tried to subscribe to a race between to Observable types.

Fixes ReactiveX#4390
Fixes ReactiveX#4642
@benlesh benlesh requested review from cartant and removed request for cartant March 15, 2019 06:37
@coveralls
Copy link

Pull Request Test Coverage Report for Build 8233

  • 1 of 1 (100.0%) changed or added relevant line in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 96.962%
Totals Coverage Status
Change from base Build 8229: 0.0%
Covered Lines: 5777
Relevant Lines: 5958
💛 - Coveralls

@benlesh benlesh merged commit fb9bc48 into ReactiveX:master Mar 15, 2019
@lock lock bot locked as resolved and limited conversation to collaborators Apr 14, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@kwonoj kwonoj kwonoj approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

race typings broken for mixed observable types in 6.4.0 Typing of the race operator
3 participants
@benlesh @coveralls @kwonoj