Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: don't reassign closed-over parameter in fromFetch #5234

Merged
merged 3 commits into from
Jan 20, 2020

Conversation

cartant
Copy link
Collaborator

@cartant cartant commented Jan 15, 2020

Description:

This PR fixes the problem reported in #5233. It:

  • adds a failing test; and
  • uses a local variable instead of reassigning to a closed-over parameter that's shared between subscribers.

Related issue (if exists): #5233

@benlesh benlesh merged commit 37d2d99 into ReactiveX:master Jan 20, 2020
benlesh pushed a commit that referenced this pull request Jan 20, 2020
* test: add failing test for #5233

* fix: don't reassign closed-over parameter in fromFetch

Closes #5233

* chore: add type annotation for variable
martinsik pushed a commit to martinsik/rxjs that referenced this pull request Feb 15, 2020
* test: add failing test for ReactiveX#5233

* fix: don't reassign closed-over parameter in fromFetch

Closes ReactiveX#5233

* chore: add type annotation for variable
@lock lock bot locked as resolved and limited conversation to collaborators Feb 21, 2020
@cartant cartant deleted the issue-5233 branch September 24, 2020 07:09
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants