fix(endWith): will properly type N arguments #5246
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
benlesh
force-pushed
the
update-endWith-types
branch
from
afef3c8
to
d0f8913
Compare
kwonoj
pushed a commit
to kwonoj/rxjs
that referenced
this pull request
Feb 5, 2020
* fix(endWith): will properly type N arguments * docs(endWith): minor improvements * docs(endWith): fix example imports
martinsik
pushed a commit
to martinsik/rxjs
that referenced
this pull request
Feb 15, 2020
* fix(endWith): will properly type N arguments * docs(endWith): minor improvements * docs(endWith): fix example imports
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
endWith now supports N-arguments for typings.. HOWEVER, if the user is using the deprecated Scheduler argument, and they are past 6 values as arguments, they will just get an incorrect type back and be forced to cast. This is an extreme corner-case though, so I feel it's worth the risk.