Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(combineLatestWith): adds combineLatestWith #5251

Merged
merged 1 commit into from
Jan 22, 2020
Merged

feat(combineLatestWith): adds combineLatestWith #5251

merged 1 commit into from
Jan 22, 2020

Conversation

benlesh
Copy link
Member

@benlesh benlesh commented Jan 21, 2020

  • creates tests for new operator
  • really just a renamed version of the old operator that was deprecated
  • updates deprecations

@benlesh
feat(combineLatestWith): adds combineLatestWith - renamed legacy comb…
60eb3b9 
…ineWith operator

- creates tests for new operator
- really just a renamed version of the old operator that was deprecated
- updates deprecations
@benlesh benlesh requested a review from cartant January 21, 2020 03:50
cartant
cartant approved these changes Jan 22, 2020
View reviewed changes
Copy link
Collaborator

@cartant cartant left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I have an idea as to how this could be made to support N-args - it ought to be possible whenever there's no scheduler - but that will have to wait until I can think a little more clearly. This is good to merge.

@cartant cartant mentioned this pull request Jan 22, 2020
Merged
@benlesh benlesh merged commit 6d7b146 into ReactiveX:master Jan 22, 2020
kwonoj pushed a commit to kwonoj/rxjs that referenced this pull request Feb 5, 2020
@benlesh @kwonoj
feat(combineLatestWith): adds combineLatestWith - renamed legacy comb…
34f4448 
…ineWith operator (ReactiveX#5251)

- creates tests for new operator
- really just a renamed version of the old operator that was deprecated
- updates deprecations
martinsik pushed a commit to martinsik/rxjs that referenced this pull request Feb 15, 2020
@benlesh
feat(combineLatestWith): adds combineLatestWith - renamed legacy comb…
2355e03 
…ineWith operator (ReactiveX#5251)

- creates tests for new operator
- really just a renamed version of the old operator that was deprecated
- updates deprecations
@lock lock bot locked as resolved and limited conversation to collaborators Feb 22, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@cartant cartant cartant approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@benlesh @cartant