Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(mergeMapTo): remove redundant/unused generic #5299

Merged
merged 1 commit into from
Apr 3, 2020
Merged

fix(mergeMapTo): remove redundant/unused generic #5299

merged 1 commit into from
Apr 3, 2020

Conversation

OliverJAsh
Copy link
Contributor

Description:
This generic is completely unused in the signature, so I don't see any reason to include it?

Added in c2ac39c

(I discovered this because of Wotan's no-uninferred-type-parameter lint rule.)

Related issue (if exists):

cartant
cartant approved these changes Feb 7, 2020
View reviewed changes
Copy link
Collaborator

@cartant cartant left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks.

@cartant cartant mentioned this pull request Feb 7, 2020
Merged
@OliverJAsh
Copy link
Contributor Author

Can this be merged?

@benlesh benlesh merged commit d67b7da into ReactiveX:master Apr 3, 2020
@benlesh
Copy link
Member

benlesh commented Apr 3, 2020

Thank you @OliverJAsh!

@lock lock bot locked as resolved and limited conversation to collaborators May 5, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@benlesh benlesh benlesh approved these changes

@cartant cartant cartant approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@OliverJAsh @benlesh @cartant