fix: fix up notification types #5478
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
benlesh
force-pushed
the
notification-types
branch
from
1c98bd6
to
07b5746
Compare
cartant
requested changes
Jun 15, 2020
cartant
approved these changes
Jun 16, 2020
| * @internal | ||
| */ | ||
| export function errorNotification(error: any): ErrorNotification { | ||
| return createNotification('E', undefined, error) as any; |
There was a problem hiding this comment.
There's one any left that could instead be an assertion (and the function could have an implicit return type).
- Ensures Notification methods only accept appropriate arguments - Ensures Arbitrary objects of the proper shape my be passed through dematerialized - Utilizes hot path functions to create lightweight objects for internal notification use - Deprecates the Notification class - Adds a deprecation message for materialize to notify users that soon the emitted object type will change to not have all of the same methods as Notification - Updates a few tests that were relying on the shape of Notification instances to pass, as we are now using POJOs internally in the TestScheduler - Adds dtslint tests for notifications - Adds dtslint tests to enforce types on dematerialize BREAKING CHANGE: Notification.createNext(undefined) will no longer return the exact same reference everytime. BREAKING CHANGE: Type signatures tightened up around Notification and dematerialize
benlesh
force-pushed
the
notification-types
branch
from
8ab5b7b
to
199869b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
BREAKING CHANGE: Notification.createNext(undefined) will no longer return the exact same reference everytime.
BREAKING CHANGE: Type signatures tightened up around Notification and dematerialize