fix(subscribeOn): allow Infinity as valid delay #5500
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Removes use of `isNumeric` that excludes `Infinity` as a valid number - Moves SubscribeOnObservable to the only location it is used. - Removes redundant tests of internals
cartant
approved these changes
Jun 16, 2020
spec/operators/subscribeOn-spec.ts
Outdated
| // const sub = ' '; | ||
|
|
||
| expectObservable(e1.pipe(subscribeOn(rxTestScheduler, Infinity))).toBe(expected); | ||
| // expectSubscriptions(e1.subscriptions).toBe(sub); |
There was a problem hiding this comment.
I would have thought that an empty array could be used:
expectSubscriptions(e1.subscriptions).toBe([]);There was a problem hiding this comment.
Ah. That makes sense. It seems like .toBe(' ') or .toBe('-------') should still work, though. I'll leave issue #5499 open
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
isNumericthat excludesInfinityas a valid number... Ultimately, I'll be visiting everything that uses
isNumericas it strikes me as strange and unnecessary.