fix(onErrorResumeNext): observables always finalized before moving to next source #5650
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
benlesh
commented
Aug 17, 2020
benlesh
commented
- Fixes an issue where finalize would be called after all sources were complete
- Removes superfluous onErrorResumeNext implementation
- Ensures that invalid sources handed to onErrorResumeNext do not cause an error, and instead resume to the next source
- Updates types to infer N arguments
- Removes invalid type signature that allowed a function for no reason
- Adds dtslint tests for static creation function
- Adds finalize test to ensure order of finalize calls (as a sanity check)
cartant
requested changes
Aug 18, 2020
… next source - Fixes an issue where finalize would be called after all sources were complete - Removes superfluous onErrorResumeNext implementation - Ensures that invalid sources handed to onErrorResumeNext do not cause an error, and instead resume to the next source - Updates types to infer N arguments - Removes invalid type signature that allowed a function for no reason - Adds dtslint tests for static creation function - Adds finalize test to ensure order of finalize calls (as a sanity check)
benlesh
force-pushed
the
onErrorResumeNext-fixes
branch
from
dc5f304
to
eb308b8
Compare
|
Rebased to resolve conflict. |
cartant
approved these changes
Sep 3, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.