Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(catchError): inner synchronous observables will properly terminate #5655

Merged
merged 2 commits into from
Aug 19, 2020
Merged

fix(catchError): inner synchronous observables will properly terminate #5655

merged 2 commits into from
Aug 19, 2020

Conversation

benlesh
Copy link
Member

@benlesh benlesh commented Aug 18, 2020

Related to #5652

@benlesh benlesh requested a review from cartant August 18, 2020 18:38
cartant
cartant approved these changes Aug 18, 2020
View reviewed changes
Copy link
Collaborator

@cartant cartant left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, the only issue seems to be an extraneous property.

src/internal/operators/catchError.ts Outdated Show resolved Hide resolved
@cartant cartant mentioned this pull request Aug 19, 2020
Closed
17 tasks
@benlesh benlesh merged commit d3fd2fb into ReactiveX:master Aug 19, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cartant cartant cartant approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@benlesh @cartant