feat(Subscription): remove will now remove any teardown by reference #5659
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, only `Subscription` instances could be removed from a `Subscription`. Now any valid `TeardownLogic` that has been added to a `Subscription` may be removed by passing the same instance to `add`.
For example:
```ts
const teardown = () => console.log('called');
const subscription = new Subscription();
subscription.add(teardown);
subscription.remove(teardown);
subscription.unsubscribe();
// Will log nothing
```
Similarly with "unsubscribables":
```ts
const unsubscribable = {
unsubscribe() {
console.log('called');
}
};
const subscription = new Subscription();
subscription.add(unsubscribable);
subscription.remove(unsubscribable);
subscription.unsubscribe();
// Will log nothing
```
- Cleans up and refactors Subscription substantially.
- Adds a few additional tests around Subscription and checking for teardown registries and unregistries
cartant
requested changes
Aug 20, 2020
- Addresses comments - Refines code a little further, moving some work closer to where it needs to be (teardowns array will no longer be allocated before we see if we even need to add anything, etc) - Rewrites conditionals in _addParent method. - Fixes test that didn't really test anything
cartant
approved these changes
Aug 21, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, only
Subscriptioninstances could be removed from aSubscription. Now any validTeardownLogicthat has been added to aSubscriptionmay be removed by passing the same instance toadd.For example:
Similarly with "unsubscribables":
Description:
Related issue (if exists):