Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fromEvent type error: Should it be thrown at Subscription time? #5823

Closed
benlesh opened this issue Oct 13, 2020 · 2 comments
Closed

fromEvent type error: Should it be thrown at Subscription time? #5823

benlesh opened this issue Oct 13, 2020 · 2 comments
Assignees

Comments

@benlesh
Copy link
Member

benlesh commented Oct 13, 2020

Currently, we have a behavior where if you provide an object to fromEvent that is not a valid target, it does not error until you try to subscribe to the result. I submit that this is probably a bad behavior, and we should notify the developer as soon as we know it's incorrect.

We have three choices:

  1. Throw on subscribe (as is)
  2. Throw when fromEvent is called.
  3. Don't throw at all and let things just fail.

I suspect that 2 is the proper choice here.

@benlesh benlesh added AGENDA ITEM Flagged for discussion at core team meetings type: discussion labels Oct 13, 2020
@benlesh
Copy link
Member Author

benlesh commented Oct 21, 2020

@cartant says "Number two" 💩

@benlesh benlesh removed the AGENDA ITEM Flagged for discussion at core team meetings label Oct 21, 2020
@benlesh benlesh self-assigned this Oct 21, 2020
@KamilSocha91
Copy link

@benlesh So this is resolved discussion and number 2 should be implemented?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants