fix(iif): No longer allow accidental undefined arguments #5829
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Updates types - Ensures that result arguments must be passed - Ensures narrower type when conditional result is known to be `true`, or known to be `false`. BREAKING CHANGE: `iif` will no longer allow result arguments that are `undefined`. This was a bad call pattern that was likely an error in most cases. If for some reason you are relying on this behavior, simply substitute `EMPTY` in place of the `undefined` argument. This ensures that the behavior was intentional and desired, rather than the result of an accidental `undefined` argument.
benlesh
force-pushed
the
fix/iif-no-undefined-arguments
branch
from
48a307c
to
b2cdd06
Compare
cartant
approved these changes
Oct 15, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
true, or known to befalse.BREAKING CHANGE:
iifwill no longer allow result arguments that areundefined. This was a bad call pattern that was likely an error in most cases. If for some reason you are relying on this behavior, simply substituteEMPTYin place of theundefinedargument. This ensures that the behavior was intentional and desired, rather than the result of an accidentalundefinedargument.