Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support emoji in marble diagrams #5907

Merged
merged 1 commit into from
Dec 6, 2020

Conversation

cartant
Copy link
Collaborator

@cartant cartant commented Nov 27, 2020

Description:

This PR adds support for emoji characters in marble diagrams by leveraging ES2015's built-in emoji support for string iteration.

An attempt to add this feature was made before - in #3857 - but that attempt sought to use toArray from lodash. This PR relies upon the built-in behaviour (and downleveled iteration for the ES5 builds):

const string = '🙈🙉🙊';
const { length } = string; // 6
const characters = [...string]; // ['🙈', '🙉', '🙊']

And, let's face it, this is something that everyone wants needs, right?

Related issue (if exists): None

@@ -88,7 +88,7 @@ describe('TestScheduler', () => {
]);
});

it('should suppport time progression syntax when runMode=true', () => {
it('should support time progression syntax when runMode=true', () => {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

supppppppppppppppppppport

@benlesh benlesh merged commit 1b4608c into ReactiveX:master Dec 6, 2020
@cartant cartant deleted the emoji-marbles branch February 21, 2021 07:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants