feat: support emoji in marble diagrams #5907
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
This PR adds support for emoji characters in marble diagrams by leveraging ES2015's built-in emoji support for string iteration.
An attempt to add this feature was made before - in #3857 - but that attempt sought to use
toArray
fromlodash
. This PR relies upon the built-in behaviour (and downleveled iteration for the ES5 builds):And, let's face it, this is something that everyone
wantsneeds, right?Related issue (if exists): None