Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

combineLatest([]) broken in 7.x #5962

Closed
benlesh opened this issue Jan 17, 2021 · 1 comment
Closed

combineLatest([]) broken in 7.x #5962

benlesh opened this issue Jan 17, 2021 · 1 comment
Assignees
@benlesh

Comments

@benlesh
Copy link
Member

benlesh commented Jan 17, 2021

It should return EMPTY, it instead returns NEVER.

Tnis is the cause of breakage in Angular router when updating to rxjs@7.

cc @leggechr
@benlesh benlesh self-assigned this Jan 17, 2021
benlesh added a commit to benlesh/rxjs that referenced this issue Jan 18, 2021
@benlesh
fix(combineLatest): Ensure EMPTY is returned if no observables are …
bcf8f8d 
…passed.

This resolves an issue found by testing Angular router. There was code that expected this behavior (rightfully so), and it was broken during a refactor in v7.

Resolves ReactiveX#5962
@jakovljevic-mladen
Copy link
Member

jakovljevic-mladen commented Jan 18, 2021 •
edited
Loading

@benlesh I tried beta.9 couple of weeks ago on my Angular project and all I was getting was the white screen. I never went digging deeper. beta.10 successfully solved the issue. Thanks a lot!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@benlesh benlesh

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@benlesh @jakovljevic-mladen