Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Translation: FAQ > Virtual DOM and Internals [Ready for review] #133

Merged
merged 4 commits into from
Feb 11, 2019

Conversation

giossa94
Copy link
Contributor

@giossa94 giossa94 commented Feb 9, 2019

The translation is ready for any feedback that you can provide @dmoralesm, @carburo, and @alejandronanez.

I'm not really happy with these points:

  • The title. I couldn't find a better translation for Internals, I thought on something like DOM virtual y la implementación de React, do you think that it is more accurate that the current one?
  • I choose to kept Shadow DOM untranslated, because DOM sombra doesn't sound really good to me. On the other hand Virtual DOM is translated to DOM Virtual, which is a bit incosistent. Do you want to keep both of them untranslated or have any other idea for this?

Relates to issue #4.

Copy link
Member

@carburo carburo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very good, really good start! I just fixed a typo in «arbol -> árbol» and changed de use of «UI» for «IU» as it is the term we are using everywhere for consistency among articles. I didn't just merge because of the issue with the title. I made some suggestions. Tell me what you think.

  • Es cierto que el título no funciona bien tal y como está. Quizá podría ser «DOM virtual y elementos internos», «DOM virtual y detalles internos» o «DOM virtual y detalles de implementación». La última es la traducción más libre y quizá no encaja del todo en el espíritu del título.
  • Creo que mantener Shadow DOM no es un problema al ser una tecnología que no está asociada a React y que hasta ahora no se utiliza para ella una traducción (por ejemplo en MDN utilizan el término sin cambiar).

content/docs/faq-internals.md Outdated Show resolved Hide resolved
content/docs/faq-internals.md Outdated Show resolved Hide resolved
@giossa94
Copy link
Contributor Author

Very good, really good start! I just fixed a typo in «arbol -> árbol» and changed de use of «UI» for «IU» as it is the term we are using everywhere for consistency among articles. I didn't just merge because of the issue with the title. I made some suggestions. Tell me what you think.

* Es cierto que el título no funciona bien tal y como está. Quizá podría ser «DOM virtual y elementos internos», «DOM virtual y detalles internos» o «DOM virtual y detalles de implementación». La última es la traducción más libre y quizá no encaja del todo en el espíritu del título.

* Creo que mantener Shadow DOM no es un problema al ser una tecnología que no está asociada a React y que hasta ahora no se utiliza para ella una traducción (por ejemplo en MDN utilizan el término sin cambiar).

Thank you! :)

About your suggestions for the title, DOM virtual y detalles de implementación is the one that sounds most natural to me. I think that detalles internos or elementos internos are less common terms on spanish literature (docs/articles/books).

@carburo
Copy link
Member

carburo commented Feb 11, 2019

Ok, very good! Ready to merge

@carburo carburo merged commit 1e816ed into reactjs:master Feb 11, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants