Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

reference-profiler-translate #280

Merged
merged 8 commits into from
Sep 10, 2019
Merged

reference-profiler-translate #280

merged 8 commits into from
Sep 10, 2019

Conversation

anodarse
Copy link
Contributor

@anodarse anodarse commented Sep 3, 2019

No description provided.

@carburo carburo mentioned this pull request Sep 3, 2019
4 tasks
@netlify
Copy link

netlify bot commented Sep 3, 2019

Deploy preview for es-reactjs ready!

Built with commit cf58e5d

https://deploy-preview-280--es-reactjs.netlify.com

@carburo carburo self-requested a review September 3, 2019 20:29
Copy link
Member

@carburo carburo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hola @anodarse, muchas gracias por esta primera contribución. 👍
Te he dejado algunos comentarios sobre algunos detalles que creo que deberíamos ver primero antes de mezclar este PR.
También noto que el título está sin traducir, creo que debería ser «API Profiler».
Dime qué crees.

content/docs/reference-profiler.md Outdated Show resolved Hide resolved
content/docs/reference-profiler.md Outdated Show resolved Hide resolved
content/docs/reference-profiler.md Outdated Show resolved Hide resolved
content/docs/reference-profiler.md Outdated Show resolved Hide resolved
content/docs/reference-profiler.md Outdated Show resolved Hide resolved
content/docs/reference-profiler.md Outdated Show resolved Hide resolved
anodarse and others added 6 commits September 9, 2019 09:43
Co-Authored-By: Rainer Martínez Fraga <[email protected]>
Co-Authored-By: Rainer Martínez Fraga <[email protected]>
Co-Authored-By: Rainer Martínez Fraga <[email protected]>
Co-Authored-By: Rainer Martínez Fraga <[email protected]>
Co-Authored-By: Rainer Martínez Fraga <[email protected]>
Co-Authored-By: Rainer Martínez Fraga <[email protected]>
@anodarse
Copy link
Contributor Author

anodarse commented Sep 9, 2019

De acuerdo con los cambios. Gracias por las sugerencias!

@carburo
Copy link
Member

carburo commented Sep 10, 2019

Thank you!

@carburo carburo merged commit 0e22560 into reactjs:master Sep 10, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants