Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Web Component translation #88

Merged
merged 5 commits into from
Feb 6, 2019
Merged

Web Component translation #88

merged 5 commits into from
Feb 6, 2019

Conversation

Paolore
Copy link
Contributor

@Paolore Paolore commented Feb 6, 2019

No description provided.

Copy link
Member

@carburo carburo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @Paolore! Nice job. Also thanks @RamirezAlex for the review.
I pointed out only the elements that must be fixed (typos). Review also the suggestions made by Alex and then we will probably be ready to merge.

content/docs/web-components.md Outdated Show resolved Hide resolved
content/docs/web-components.md Outdated Show resolved Hide resolved
content/docs/web-components.md Outdated Show resolved Hide resolved
content/docs/web-components.md Outdated Show resolved Hide resolved
content/docs/web-components.md Outdated Show resolved Hide resolved
content/docs/web-components.md Outdated Show resolved Hide resolved
@RamirezAlex
Copy link
Contributor

Nice job @Paolore LGTM 👍

@carburo
Copy link
Member

carburo commented Feb 6, 2019

Hi @Paolore, I was writing about the rationale behind not translating WebComponent and then you updated it. Great work with this PR!

@carburo carburo merged commit a8a30c1 into reactjs:master Feb 6, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants