Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Translate Higher-Order-Components #103

Merged
merged 18 commits into from
Feb 12, 2019

Conversation

satotake
Copy link
Contributor

@satotake satotake commented Feb 9, 2019

@tesseralis tesseralis mentioned this pull request Feb 9, 2019
90 tasks
@smikitky smikitky self-requested a review February 9, 2019 16:59
@smikitky smikitky added the 🚫 in intial review 初期レビューの真っ最中 label Feb 9, 2019
Copy link
Member

@smikitky smikitky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

確認しました、よろしくお願いします。

  • 数が多くなりましたが大半はスペースなどの問題です。
  • ところどころで原文にない改行が含まれていますが、翻訳前と行レベルで合致するようにしてください。GitHubの差分ページで見たときに左右が完全に対応しているのが理想です。将来原文が更新されたりしたときのマージのやりやすさにも影響を与えてしまいます。

content/docs/higher-order-components.md Outdated Show resolved Hide resolved
content/docs/higher-order-components.md Outdated Show resolved Hide resolved
content/docs/higher-order-components.md Outdated Show resolved Hide resolved
content/docs/higher-order-components.md Outdated Show resolved Hide resolved
content/docs/higher-order-components.md Outdated Show resolved Hide resolved
content/docs/higher-order-components.md Outdated Show resolved Hide resolved
content/docs/higher-order-components.md Outdated Show resolved Hide resolved
content/docs/higher-order-components.md Outdated Show resolved Hide resolved
content/docs/higher-order-components.md Outdated Show resolved Hide resolved
content/docs/higher-order-components.md Outdated Show resolved Hide resolved
@smikitky smikitky removed the 🚫 in intial review 初期レビューの真っ最中 label Feb 9, 2019
@satotake
Copy link
Contributor Author

satotake commented Feb 10, 2019

@smikitky
迅速かつ正確にレビューしていただきありがとうございました
レビューで指摘された点に加えて、1点だけ追加修正しました
render メソッド という表現と レンダーメソッド という表現が混在していたので、前者に揃えました

Copy link
Member

@smikitky smikitky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

文章についてはこれで大丈夫です。
不要な空行や改行がわずかに残っているため、こちらだけ対応をお願いします。

content/docs/higher-order-components.md Outdated Show resolved Hide resolved
content/docs/higher-order-components.md Show resolved Hide resolved
content/docs/higher-order-components.md Outdated Show resolved Hide resolved
@satotake
Copy link
Contributor Author

@smikitky 指摘した頂いた、空行・改行について修正しました

@smikitky
Copy link
Member

ありがとうございました。他の方のレビューをお待ち下さい。

Copy link
Member

@koba04 koba04 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@satotake 1点だけ改行の削除お願いします 🙏 その他はOKだと思います! 👍

content/docs/higher-order-components.md Show resolved Hide resolved
Copy link
Member

@koba04 koba04 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

すみません。Status間違いました...

@koba04
Copy link
Member

koba04 commented Feb 12, 2019

@satotake #98 で追加されたtextlintのチェックに引っかかっているので、そこだけ修正お願いします 🙇
CIが通ればmergeします。

@satotake
Copy link
Contributor Author

@koba04 通りました、ありがとうございました!

@koba04 koba04 merged commit 92a0e26 into reactjs:master Feb 12, 2019
@koba04
Copy link
Member

koba04 commented Feb 12, 2019

@satotake mergeしました! 🎉🎉 ありがとうございます!! 👏👏👏

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants