Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Translate thinking-in-react #16

Merged
merged 40 commits into from
Feb 5, 2019
Merged

Conversation

Nkzn
Copy link

@Nkzn Nkzn commented Feb 1, 2019

Translation for Thinking in React.

#4

@smikitky
Copy link
Member

smikitky commented Feb 3, 2019

UIを 1要素 などでも半角スペース挿入をお願いします

@Nkzn Nkzn changed the title WIP: Translate thinking-in-react Translate thinking-in-react Feb 3, 2019
@koba04 koba04 self-requested a review February 4, 2019 01:15
Copy link
Member

@koba04 koba04 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Nkzn
いくつかフォーマットとtypoを修正したので確認お願いします! 🙇

content/docs/thinking-in-react.md Outdated Show resolved Hide resolved
content/docs/thinking-in-react.md Outdated Show resolved Hide resolved
content/docs/thinking-in-react.md Outdated Show resolved Hide resolved
content/docs/thinking-in-react.md Outdated Show resolved Hide resolved
Copy link
Member

@smikitky smikitky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

こちらで確認をお願いします。全体に「あなた」が他の記事より多用されていたため、減らして簡潔な表現に寄せたりしています。

content/docs/thinking-in-react.md Outdated Show resolved Hide resolved
content/docs/thinking-in-react.md Outdated Show resolved Hide resolved
content/docs/thinking-in-react.md Outdated Show resolved Hide resolved
content/docs/thinking-in-react.md Outdated Show resolved Hide resolved
content/docs/thinking-in-react.md Outdated Show resolved Hide resolved
content/docs/thinking-in-react.md Outdated Show resolved Hide resolved
content/docs/thinking-in-react.md Outdated Show resolved Hide resolved
content/docs/thinking-in-react.md Outdated Show resolved Hide resolved
content/docs/thinking-in-react.md Outdated Show resolved Hide resolved
content/docs/thinking-in-react.md Outdated Show resolved Hide resolved
@Nkzn
Copy link
Author

Nkzn commented Feb 5, 2019

suggested change同士でコンフリクトした場合の対応ってどうしたらいいんでしょう・・・(いくつかoutdatedになってしまった)

@smikitky
Copy link
Member

smikitky commented Feb 5, 2019

妥当だと思われる文章で普通に手でコミットしていただけると。

@Nkzn
Copy link
Author

Nkzn commented Feb 5, 2019

@smikitky @koba04 レビューありがとうございました! 修正しました!

@smikitky
Copy link
Member

smikitky commented Feb 5, 2019

私はこれで大丈夫そうです

Copy link
Member

@koba04 koba04 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Nkzn 一点、「。」が抜けている部分があったのでそこだけ対応お願いします 🙇
そのほかはOKだと思います! 🎉

content/docs/thinking-in-react.md Outdated Show resolved Hide resolved
@Nkzn
Copy link
Author

Nkzn commented Feb 5, 2019

@koba04 すいませんでした・・・!!!!!!!

@koba04 koba04 merged commit 1ef8830 into reactjs:master Feb 5, 2019
@koba04
Copy link
Member

koba04 commented Feb 5, 2019

@Nkzn ありがとうございます!マージしました 🎉🎉🎉

@Nkzn
Copy link
Author

Nkzn commented Feb 5, 2019

ありがとうございました🙌

@tesseralis tesseralis mentioned this pull request Feb 5, 2019
90 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants