Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Translate render-props #49

Merged
merged 15 commits into from
Feb 6, 2019
Merged

Translate render-props #49

merged 15 commits into from
Feb 6, 2019
+34 −34

Conversation

ossan-engineer
Copy link
Contributor

This PR is part of Issue #4.

@tesseralis tesseralis mentioned this pull request Feb 3, 2019
Closed
90 tasks
@ossan-engineer ossan-engineer changed the title [WIP] Translate render-props Translate render-props Feb 3, 2019
@koba04 koba04 self-requested a review February 4, 2019 01:16
@smikitky smikitky self-requested a review February 4, 2019 09:04
@koba04 koba04 removed their request for review February 4, 2019 09:40
@sasurau4
Copy link
Contributor

sasurau4 commented Feb 4, 2019

今からレビューします 🌠

sasurau4
sasurau4 suggested changes Feb 4, 2019
View reviewed changes
Copy link
Contributor

@sasurau4 sasurau4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ありがとうございます 👍
大量に指摘しましたが、自信がない部分も多々あるのでコメントをいただけると 🙏
対応よろしくお願いします。

content/docs/render-props.md Outdated Show resolved Hide resolved
content/docs/render-props.md Outdated Show resolved Hide resolved
content/docs/render-props.md Outdated Show resolved Hide resolved
content/docs/render-props.md Outdated Show resolved Hide resolved
content/docs/render-props.md Outdated Show resolved Hide resolved
content/docs/render-props.md Outdated Show resolved Hide resolved
content/docs/render-props.md Outdated Show resolved Hide resolved
content/docs/render-props.md Outdated Show resolved Hide resolved
content/docs/render-props.md Outdated Show resolved Hide resolved
content/docs/render-props.md Outdated Show resolved Hide resolved
smikitky
smikitky requested changes Feb 5, 2019
View reviewed changes
Copy link
Member

@smikitky smikitky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

幾つか改善点を見つけましたので対応をお願いいたします。

content/docs/render-props.md Outdated Show resolved Hide resolved
content/docs/render-props.md Outdated Show resolved Hide resolved
content/docs/render-props.md Show resolved Hide resolved
content/docs/render-props.md Outdated Show resolved Hide resolved
content/docs/render-props.md Outdated Show resolved Hide resolved
content/docs/render-props.md Outdated Show resolved Hide resolved
content/docs/render-props.md Outdated Show resolved Hide resolved
content/docs/render-props.md Outdated Show resolved Hide resolved
content/docs/render-props.md Outdated Show resolved Hide resolved
content/docs/render-props.md Outdated Show resolved Hide resolved
@ossan-engineer
Apply suggestions from code review
02fdce9 
Co-Authored-By: ossan-engineer <[email protected]>
@smikitky
Copy link
Member

smikitky commented Feb 6, 2019

最終文以外は確認しました。

@ossan-engineer
Copy link
Contributor Author

@smikitky ありがとうございます！

@koba04 koba04 self-requested a review February 6, 2019 04:21
koba04
koba04 requested changes Feb 6, 2019
View reviewed changes
Copy link
Member

@koba04 koba04 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

不要な改行と、わかりやすさを重視して「関数型 props」の言い方を単純に「関数の props」に変えてみたので確認お願いします。

content/docs/render-props.md Outdated Show resolved Hide resolved
content/docs/render-props.md Outdated Show resolved Hide resolved
content/docs/render-props.md Outdated Show resolved Hide resolved
content/docs/render-props.md Outdated Show resolved Hide resolved
content/docs/render-props.md Show resolved Hide resolved
smikitky
smikitky approved these changes Feb 6, 2019
View reviewed changes
Copy link
Member

@smikitky smikitky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

一応1個だけスペースの抜けを見つけたので修正お願いします。（レビューは approve にしておきます）

content/docs/render-props.md Outdated Show resolved Hide resolved
@ossan-engineer
Copy link
Contributor Author

@koba04 @smikitky @sasurau4 諸々修正しましたので、お手すきでご確認お願いいたします。

@koba04 koba04 merged commit 9680e25 into reactjs:master Feb 6, 2019
@koba04
Copy link
Member

koba04 commented Feb 6, 2019

@ossan-engineer mergeしました！！ 🎉 ありがとうございます！ 👏👏👏

@ossan-engineer
Copy link
Contributor Author

@koba04 ありがとうございます！

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sasurau4 sasurau4 sasurau4 requested changes

@koba04 koba04 koba04 approved these changes

@smikitky smikitky smikitky approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ossan-engineer @sasurau4 @smikitky @koba04