Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Translate Refs and the DOM #52

Merged
merged 34 commits into from
Feb 8, 2019
Merged

Translate Refs and the DOM #52

merged 34 commits into from
Feb 8, 2019

Conversation

y-temp4
Copy link
Contributor

@y-temp4 y-temp4 commented Feb 3, 2019 •
edited
Loading

This PR is a part of #4.

@y-temp4
Copy link
Contributor Author

y-temp4 commented Feb 3, 2019

assign @smikitky as a reviewer

ですが、変更できなかったため、No reviews となっています。
レビューをお願いします🙏

@smikitky smikitky self-requested a review February 4, 2019 00:50
@koba04 koba04 requested review from koba04 and removed request for koba04 February 4, 2019 01:17
@sasurau4
Copy link
Contributor

sasurau4 commented Feb 5, 2019

レビューします 👍

@tesseralis tesseralis mentioned this pull request Feb 5, 2019
Closed
90 tasks
sasurau4
sasurau4 suggested changes Feb 5, 2019
View reviewed changes
Copy link
Contributor

@sasurau4 sasurau4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

翻訳ありがとうございます 👍
結構、コメントしましたので確認お願いします 🙏

content/docs/refs-and-the-dom.md Outdated Show resolved Hide resolved
content/docs/refs-and-the-dom.md Outdated Show resolved Hide resolved
content/docs/refs-and-the-dom.md Outdated Show resolved Hide resolved
content/docs/refs-and-the-dom.md Outdated Show resolved Hide resolved
content/docs/refs-and-the-dom.md Outdated Show resolved Hide resolved
content/docs/refs-and-the-dom.md Outdated Show resolved Hide resolved
content/docs/refs-and-the-dom.md Outdated Show resolved Hide resolved
content/docs/refs-and-the-dom.md Outdated Show resolved Hide resolved
content/docs/refs-and-the-dom.md Outdated

### Legacy API: String Refs
### レガシー API：String Refs
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
### レガシー API：String Refs
### レガシー API：文字列 Refs

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

String 訳さなくてもいいかも 🤔

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

個人的には訳さなくても良いかと思います！

content/docs/refs-and-the-dom.md Outdated Show resolved Hide resolved
@y-temp4
Copy link
Contributor Author

y-temp4 commented Feb 5, 2019

@sasurau4 レビューありがとうございます！
後ほど確認させていただきます🙏

sasurau4 and others added 21 commits February 5, 2019 21:41
@sasurau4 @y-temp4
Update content/docs/refs-and-the-dom.md
6b37062 
Co-Authored-By: y-temp4 <[email protected]>
@sasurau4 @y-temp4
Update content/docs/refs-and-the-dom.md
dcbff65 
Co-Authored-By: y-temp4 <[email protected]>
@sasurau4 @y-temp4
Update content/docs/refs-and-the-dom.md
248c894 
Co-Authored-By: y-temp4 <[email protected]>
@sasurau4 @y-temp4
Update content/docs/refs-and-the-dom.md
93834c8 
Co-Authored-By: y-temp4 <[email protected]>
@sasurau4 @y-temp4
Update content/docs/refs-and-the-dom.md
e01c265 
Co-Authored-By: y-temp4 <[email protected]>
@sasurau4 @y-temp4
Update content/docs/refs-and-the-dom.md
5e13d8c 
Co-Authored-By: y-temp4 <[email protected]>
@sasurau4 @y-temp4
Update content/docs/refs-and-the-dom.md
2d0d2aa 
Co-Authored-By: y-temp4 <[email protected]>
@y-temp4
doc: Remove useless space
d3d0c48
@sasurau4 @y-temp4
Update content/docs/refs-and-the-dom.md
7a3d828 
Co-Authored-By: y-temp4 <[email protected]>
@sasurau4 @y-temp4
Update content/docs/refs-and-the-dom.md
61def37 
Co-Authored-By: y-temp4 <[email protected]>
@sasurau4 @y-temp4
Update content/docs/refs-and-the-dom.md
b59152d 
Co-Authored-By: y-temp4 <[email protected]>
@sasurau4 @y-temp4
Update content/docs/refs-and-the-dom.md
5c8c172 
Co-Authored-By: y-temp4 <[email protected]>
@y-temp4
doc: Remove useless space
e6c397c
@sasurau4 @y-temp4
Update content/docs/refs-and-the-dom.md
ec7f289 
Co-Authored-By: y-temp4 <[email protected]>
@sasurau4 @y-temp4
Update content/docs/refs-and-the-dom.md
770c934 
Co-Authored-By: y-temp4 <[email protected]>
@sasurau4 @y-temp4
Update content/docs/refs-and-the-dom.md
8b5b402 
Co-Authored-By: y-temp4 <[email protected]>
@sasurau4 @y-temp4
Update content/docs/refs-and-the-dom.md
9912ddc 
Co-Authored-By: y-temp4 <[email protected]>
@sasurau4 @y-temp4
Update content/docs/refs-and-the-dom.md
f96ab8f 
Co-Authored-By: y-temp4 <[email protected]>
@sasurau4 @y-temp4
Update content/docs/refs-and-the-dom.md
976ff03 
Co-Authored-By: y-temp4 <[email protected]>
@sasurau4 @y-temp4
Update content/docs/refs-and-the-dom.md
a13fd52 
Co-Authored-By: y-temp4 <[email protected]>
@sasurau4 @y-temp4
Update content/docs/refs-and-the-dom.md
7b7b334 
Co-Authored-By: y-temp4 <[email protected]>
@y-temp4
Copy link
Contributor Author

y-temp4 commented Feb 5, 2019

@sasurau4 #52 (comment) と #52 (comment) 以外は一旦変更を取り入れさせていただきました！
丁寧なご指摘、ありがとうございました😄

@smikitky
Copy link
Member

smikitky commented Feb 5, 2019 •
edited
Loading

1つ1つの修正で全部コミットを作るのは大変なのでバッチコミットの機能を使ってください。"Files Changed"のタブの方で使えます。

あと key とかもそうですが、見出しなどで refs となっていたとしても、 ref は単体で使うので基本単数形で訳してください。(props は prop の塊なので props ですが）

@y-temp4
Copy link
Contributor Author

y-temp4 commented Feb 6, 2019

@smikitky 承知しました🙇‍♂️
refs に関して修正させていただきます🙏

@y-temp4
Copy link
Contributor Author

y-temp4 commented Feb 6, 2019

@smikitky refs に関して、修正させていただきました🙏

@koba04
Copy link
Member

koba04 commented Feb 6, 2019

@y-temp4 タイトル部分などまだRefsの表記が残っているようなので確認お願いします 🙏

@koba04 koba04 mentioned this pull request Feb 6, 2019
Merged
@y-temp4
Copy link
Contributor Author

y-temp4 commented Feb 7, 2019

@koba04 一通り Refs を Ref に変更したので、確認をお願いします🙏

smikitky
smikitky requested changes Feb 7, 2019
View reviewed changes
Copy link
Member

@smikitky smikitky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

軽微なものばかりですが、確認しましたのでいくつか対応をお願いします。

content/docs/refs-and-the-dom.md Outdated Show resolved Hide resolved
content/docs/refs-and-the-dom.md Outdated Show resolved Hide resolved
content/docs/refs-and-the-dom.md Outdated Show resolved Hide resolved
content/docs/refs-and-the-dom.md Outdated Show resolved Hide resolved
content/docs/refs-and-the-dom.md Outdated Show resolved Hide resolved
content/docs/refs-and-the-dom.md Outdated Show resolved Hide resolved
content/docs/refs-and-the-dom.md Outdated Show resolved Hide resolved
content/docs/refs-and-the-dom.md Outdated Show resolved Hide resolved
content/docs/refs-and-the-dom.md Outdated Show resolved Hide resolved
@y-temp4
Copy link
Contributor Author

y-temp4 commented Feb 7, 2019

@smikitky 修正させていただきました！
ご指摘ありがとうございました🙏

koba04
koba04 requested changes Feb 7, 2019
View reviewed changes
Copy link
Member

@koba04 koba04 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@y-temp4 細かい点をいくつかコメントしましたので確認お願いします 🙇

content/docs/refs-and-the-dom.md Outdated Show resolved Hide resolved
content/docs/refs-and-the-dom.md Outdated Show resolved Hide resolved
content/docs/refs-and-the-dom.md Outdated Show resolved Hide resolved
content/docs/refs-and-the-dom.md Outdated Show resolved Hide resolved
@y-temp4
Copy link
Contributor Author

y-temp4 commented Feb 8, 2019

@koba04 変更を反映させていただきました！
ご指摘ありがとうございます🙏

@koba04 koba04 merged commit aff8f2f into reactjs:master Feb 8, 2019
@koba04
Copy link
Member

koba04 commented Feb 8, 2019

@y-temp4 ありがとうございます、mergeしました！！ 👏👏👏

@smikitky
Copy link
Member

smikitky commented Feb 8, 2019

@y-temp4 ありがとうございました！

@koba04 #96 が進行中なので、個別記事のマージよりそちらを先にした方が幸せかもしれません。これは個別に対処します。

@smikitky smikitky mentioned this pull request Feb 8, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sasurau4 sasurau4 sasurau4 requested changes

@koba04 koba04 koba04 approved these changes

@smikitky smikitky smikitky approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@y-temp4 @sasurau4 @smikitky @koba04