Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Translate react-without-es6 #53

Merged
merged 23 commits into from
Feb 4, 2019
Merged

Conversation

ginpei
Copy link
Contributor

@ginpei ginpei commented Feb 3, 2019

Advanced Guides > React Without ES6の翻訳です。

Copy link
Contributor Author

@ginpei ginpei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

assign @smikitky as a reviewer

とのことでしたが、変更できないので no reviews のままです。すみません、レビューお願いします!

content/docs/react-without-es6.md Show resolved Hide resolved
content/docs/react-without-es6.md Outdated Show resolved Hide resolved
content/docs/react-without-es6.md Show resolved Hide resolved
content/docs/react-without-es6.md Outdated Show resolved Hide resolved
@smikitky smikitky self-requested a review February 3, 2019 08:21
Copy link
Member

@smikitky smikitky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

レビューしましたのでこちらの確認をよろしくお願いします!

content/docs/react-without-es6.md Outdated Show resolved Hide resolved
content/docs/react-without-es6.md Outdated Show resolved Hide resolved
content/docs/react-without-es6.md Outdated Show resolved Hide resolved
content/docs/react-without-es6.md Outdated Show resolved Hide resolved
content/docs/react-without-es6.md Outdated Show resolved Hide resolved
content/docs/react-without-es6.md Outdated Show resolved Hide resolved
content/docs/react-without-es6.md Outdated Show resolved Hide resolved
content/docs/react-without-es6.md Outdated Show resolved Hide resolved
content/docs/react-without-es6.md Outdated Show resolved Hide resolved
content/docs/react-without-es6.md Outdated Show resolved Hide resolved
@tesseralis tesseralis mentioned this pull request Feb 3, 2019
90 tasks
smikitky and others added 17 commits February 3, 2019 10:53
@ginpei
Copy link
Contributor Author

ginpei commented Feb 3, 2019

納得のいく suggestions だったので一通り取り込みました。

@koba04 koba04 self-requested a review February 4, 2019 01:17
@smikitky
Copy link
Member

smikitky commented Feb 4, 2019

私の方ではOKです。@koba04 さん待ち。

Copy link
Member

@koba04 koba04 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ginpei 不要なーがあったのでその点だけコメントしました!

content/docs/react-without-es6.md Outdated Show resolved Hide resolved
content/docs/react-without-es6.md Outdated Show resolved Hide resolved
@ginpei
Copy link
Contributor Author

ginpei commented Feb 4, 2019

そのルールを失念しておりました。自分でも見直して修正しました。 🙏

@ginpei
Copy link
Contributor Author

ginpei commented Feb 4, 2019

「レガシー」は一般的なカタカナ日本語と判断して残しました。

@smikitky smikitky merged commit 7c6584b into reactjs:master Feb 4, 2019
@smikitky
Copy link
Member

smikitky commented Feb 4, 2019

ありがとうございました!

@ginpei ginpei deleted the react-without-es6 branch February 14, 2019 03:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants