Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Translate fragments #92

Merged
merged 6 commits into from
Feb 7, 2019
Merged

Conversation

shooontan
Copy link
Contributor

This PR is part of #4

Translation of Fragments

Please review 🙏

@smikitky smikitky added the 🚫 in intial review 初期レビューの真っ最中 label Feb 7, 2019
Copy link
Member

@smikitky smikitky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

小さな修正のみですが対応よろしくお願いします。

content/docs/fragments.md Outdated Show resolved Hide resolved
content/docs/fragments.md Outdated Show resolved Hide resolved
content/docs/fragments.md Outdated Show resolved Hide resolved
content/docs/fragments.md Outdated Show resolved Hide resolved
@smikitky smikitky removed the 🚫 in intial review 初期レビューの真っ最中 label Feb 7, 2019
@shooontan
Copy link
Contributor Author

レビューありがとうございます!

suggestion取り込みましたので再度よろしくお願いします 🙇

Copy link
Member

@smikitky smikitky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

もう1件見逃していました。見出しのアンカーのURLはすべて英字のまま一切変えないでください。 reactjs/react.dev#1608 でまとめて直ります。申し訳ありませんがよろしくお願いします。

content/docs/fragments.md Outdated Show resolved Hide resolved
Copy link
Member

@potato4d potato4d left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@shooontan
翻訳ありがとうございます!良さそうです ✨

@potato4d potato4d merged commit aa8a90d into reactjs:master Feb 7, 2019
@tesseralis tesseralis mentioned this pull request Feb 9, 2019
90 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants