Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Translate static type checking #103

Merged
merged 18 commits into from
Mar 13, 2019
Merged

Translate static type checking #103

merged 18 commits into from
Mar 13, 2019

Conversation

ericp3reira
Copy link
Contributor

@ericp3reira ericp3reira commented Feb 17, 2019 •
edited
Loading

Hello, everyone!

I'm still working on this doc, but I'm opening this PR if you people want to start reviewing. 😄

Thanks!

halian-vilela
halian-vilela requested changes Feb 18, 2019
View reviewed changes
Copy link
Collaborator

@halian-vilela halian-vilela left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Massa @ericp3reira

Já dei meus dois cents aí, vou adicionar as tags e vc vai nos avisando à medida que progredir!

Valeu!

content/docs/static-type-checking.md Outdated Show resolved Hide resolved
content/docs/static-type-checking.md Outdated Show resolved Hide resolved
content/docs/static-type-checking.md Outdated Show resolved Hide resolved
content/docs/static-type-checking.md Outdated Show resolved Hide resolved
@halian-vilela halian-vilela added work in progress Author opened the pull-request but it's still being worked on needs author response Changes requested needing author's input needs +1 Needs another approval before merging labels Feb 18, 2019
@ericp3reira
Copy link
Contributor Author

Valeu, @halian-vilela! Achei as sugestões pertinentes e já commitei todas. 😄

@tesseralis tesseralis mentioned this pull request Feb 19, 2019
Closed
90 tasks
@halian-vilela halian-vilela added 💪 long page - more than 100 lines Long page and removed needs author response Changes requested needing author's input labels Feb 20, 2019
@halian-vilela halian-vilela self-assigned this Feb 20, 2019
@halian-vilela
Copy link
Collaborator

Valeu, @halian-vilela! Achei as sugestões pertinentes e já commitei todas. 😄

Massa @ericp3reira !

Adicionei o label de artigo longo, se vc precisar de um help pra traduzir essa segunda metade avisa ao pessoal lá na issue principal ( #1 ), blz?

Abraços!

michellocana
michellocana suggested changes Feb 20, 2019
View reviewed changes
content/docs/static-type-checking.md Show resolved Hide resolved
content/docs/static-type-checking.md Outdated Show resolved Hide resolved
@ericp3reira
Copy link
Contributor Author

Massa @ericp3reira !

Adicionei o label de artigo longo, se vc precisar de um help pra traduzir essa segunda metade avisa ao pessoal lá na issue principal ( #1 ), blz?

Abraços!

Opa! Obrigado, @halian-vilela!
Por enquanto está tranquilo. Fim de semana termino, sem problemas. Se tiver algum impedimento, mando um aviso pra galera. 😄

@netlify
Copy link

netlify bot commented Feb 20, 2019

Deploy preview for pt-br-reactjs ready!

Built with commit fa623e4

https://deploy-preview-103--pt-br-reactjs.netlify.com

@netlify
Copy link

netlify bot commented Feb 20, 2019 •
edited
Loading

Deploy preview for pt-br-reactjs ready!

Built with commit 7f68b26

https://deploy-preview-103--pt-br-reactjs.netlify.com

@glaucia86 glaucia86 added needs author response Changes requested needing author's input and removed needs +1 Needs another approval before merging labels Feb 25, 2019
@glaucia86
Copy link
Member

@ericp3reira precisa de ajuda ajuda? Se passar mais alguns dias, podemos passar essa PR para uma outra pessoa te ajudar. O que pensa a respeito?

cc: @halian-vilela - se passar mais 7 dias, melhor passar para uma outra pessoa. ;)

@ericp3reira
Copy link
Contributor Author

@glaucia86 Estou terminando. Acredito que hoje mesmo. :)

@glaucia86
Copy link
Member

@glaucia86 Estou terminando. Acredito que hoje mesmo. :)

Show @ericp3reira. Assim que terminar, nos sinalize com cc: @glaucia86 @halian-vilela @jhonmike ;)

@halian-vilela
Copy link
Collaborator

@ericp3reira

Oi Eric, blz? Como está o progresso dessa tradução? Se vc achar que tá apertado, terei um tempo hoje, posso finalizar essa pra ti e a gente já commita e mergeia. Já que o restante já está revisado.

Caso consiga fazer, nos avise!

Tá faltando pouco pra fechar o core!

cc: @glaucia86 @jhonmike

@ericp3reira
Copy link
Contributor Author

@ericp3reira

Oi Eric, blz? Como está o progresso dessa tradução? Se vc achar que tá apertado, terei um tempo hoje, posso finalizar essa pra ti e a gente já commita e mergeia. Já que o restante já está revisado.

Caso consiga fazer, nos avise!

Tá faltando pouco pra fechar o core!

cc: @glaucia86 @jhonmike

E aí, @halian-vilela?

Eu queria terminar hoje cedo, mas estou viajando e só poderia finalizar no fim do dia. Agradeço se quiser assumir o PR e terminar o que falta. :)

Parabéns pelo ótiimo trabalho, pessoal! Foi fantástico participar destas traduções. 😄

@ericp3reira
Copy link
Contributor Author

Finalizado, pessoal! Aguardo os reviews. :)

cc @glaucia86 @halian-vilela @jhonmike

@ericp3reira ericp3reira changed the title WIP: Translate static type checking Translate static type checking Mar 11, 2019
@jhonmike jhonmike removed the work in progress Author opened the pull-request but it's still being worked on label Mar 11, 2019
@eduardomoroni eduardomoroni added feedback addressed and removed needs author response Changes requested needing author's input labels Mar 11, 2019
jhonmike
jhonmike previously approved these changes Mar 11, 2019
View reviewed changes
@jhonmike jhonmike added needs +1 Needs another approval before merging and removed feedback addressed labels Mar 11, 2019
halian-vilela
halian-vilela requested changes Mar 13, 2019
View reviewed changes
Copy link
Collaborator

@halian-vilela halian-vilela left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ericp3reira

Cara, só 2 pequenos errinhos de ortografia no úúúltimo parágrafo, ahaha, eu já ia aprovar e mandar bala no merge quando vi, quase chorei aqui.

Mas ajusta aí que a gente já aprova. Muito obrigado pela tradução, ficou excelente!

content/docs/static-type-checking.md Outdated Show resolved Hide resolved
@halian-vilela halian-vilela added needs author response Changes requested needing author's input and removed needs +1 Needs another approval before merging labels Mar 13, 2019
@ericp3reira
Copy link
Contributor Author

@ericp3reira

Cara, só 2 pequenos errinhos de ortografia no úúúltimo parágrafo, ahaha, eu já ia aprovar e mandar bala no merge quando vi, quase chorei aqui.

Mas ajusta aí que a gente já aprova. Muito obrigado pela tradução, ficou excelente!

Feito, @halian-vilela! :D

@jhonmike jhonmike merged commit 61a202c into reactjs:master Mar 13, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@halian-vilela halian-vilela halian-vilela requested changes

@michellocana michellocana michellocana requested changes

@jhonmike jhonmike jhonmike approved these changes

Assignees

@halian-vilela halian-vilela

@jhonmike jhonmike

Labels
💪 long page - more than 100 lines Long page needs author response Changes requested needing author's input
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@ericp3reira @halian-vilela @glaucia86 @jhonmike @michellocana @eduardomoroni