Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ajuste do Menu e tradução dos menus laterais #135

Merged
merged 10 commits into from
Mar 6, 2019
Merged

Ajuste do Menu e tradução dos menus laterais #135

merged 10 commits into from
Mar 6, 2019

Conversation

jhonmike
Copy link
Member

@jhonmike jhonmike commented Feb 28, 2019 •
edited
Loading

image
image
image

@jhonmike jhonmike mentioned this pull request Feb 28, 2019
Closed
@netlify
Copy link

netlify bot commented Feb 28, 2019 •
edited
Loading

Deploy preview for pt-br-reactjs ready!

Built with commit 643e8d7

https://deploy-preview-135--pt-br-reactjs.netlify.com

@jhonmike jhonmike changed the title Ajuste do Menu e tradução do menu lateral da seção comunidade. Ajuste do Menu e tradução dos menus laterais Feb 28, 2019
glaucia86
glaucia86 requested changes Mar 3, 2019
View reviewed changes
Copy link
Member

@glaucia86 glaucia86 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jhonmike faz as alterações listadas que aprovarei e farei o merge para a documentação principal.

Muito obrigada pela sua contribuição! :)

content/community/nav.yml Outdated Show resolved Hide resolved
content/docs/nav.yml Outdated Show resolved Hide resolved
content/docs/nav.yml Outdated Show resolved Hide resolved
@glaucia86 glaucia86 added needs review A pull request ready to be reviewed needs author response Changes requested needing author's input labels Mar 3, 2019
@jhonmike jhonmike removed the needs author response Changes requested needing author's input label Mar 3, 2019
@halian-vilela
Copy link
Collaborator

@jhonmike
Já fez o commit resolvendo a questão do espaçamento? Se sim, acho que o resto já está ok né?

Podemos fazer o merge?

cc: @glaucia86

@glaucia86
Copy link
Member

@jhonmike
Já fez o commit resolvendo a questão do espaçamento? Se sim, acho que o resto já está ok né?

Podemos fazer o merge?

cc: @glaucia86

No aguardo da resposta do @jhonmike

@glaucia86 glaucia86 added needs author response Changes requested needing author's input and removed needs review A pull request ready to be reviewed labels Mar 5, 2019
@lffg lffg mentioned this pull request Mar 5, 2019
Closed
@jhonmike
Copy link
Member Author

jhonmike commented Mar 6, 2019

@halian-vilela @glaucia86 sim já fiz os ajustes, estava mesmo esperando a aprovação do PR haha :)

@jhonmike jhonmike added needs +1 Needs another approval before merging and removed needs author response Changes requested needing author's input labels Mar 6, 2019
@jhonmike jhonmike mentioned this pull request Mar 6, 2019
Merged
glaucia86
glaucia86 approved these changes Mar 6, 2019
View reviewed changes
Copy link
Member

@glaucia86 glaucia86 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jhonmike muito obrigada pela sua contribuição!

LGTM 👍

@glaucia86
Copy link
Member

cc: @halian-vilela só aprovar e mergear esse PR :)

@jhonmike jhonmike added 🌐 translated Translation is completed for this page and removed needs +1 Needs another approval before merging labels Mar 6, 2019
@jhonmike
Copy link
Member Author

jhonmike commented Mar 6, 2019

Vou dar "Merge" pois, este PR corrige o bug no menu duplicado que já esta no ar.

@jhonmike jhonmike merged commit e252674 into reactjs:master Mar 6, 2019
@tesseralis tesseralis mentioned this pull request Mar 7, 2019
Closed
90 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@glaucia86 glaucia86 glaucia86 approved these changes

@eduardomoroni eduardomoroni Awaiting requested review from eduardomoroni

Assignees
No one assigned
Labels
🌐 translated Translation is completed for this page
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jhonmike @halian-vilela @glaucia86