Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Translate Home Page #2

Closed
wants to merge 0 commits into from
Closed

Translate Home Page #2

wants to merge 0 commits into from

Conversation

gnuns
Copy link
Contributor

@gnuns gnuns commented Feb 8, 2019

  • src/pages/index.js
  • content/home/marketing
    • component-based
    • declarative
    • learn-once-write-anywhere
  • content/home/examples
    • a-component-using-external-plugins
    • a-simple-component
    • a-stateful-component
    • an-application

@WendellAdriel
Copy link
Member

Please don't forget to take a look at #4 when translating!!!

@glaucia86 glaucia86 added the needs review A pull request ready to be reviewed label Feb 8, 2019
Copy link
Member

@glaucia86 glaucia86 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

need some few changes @gnuns

@cezaraugusto
Copy link
Member

since PR title says WIP I'm moving from waiting for reviewers to work in progress

@cezaraugusto cezaraugusto added work in progress Author opened the pull-request but it's still being worked on and removed needs review A pull request ready to be reviewed labels Feb 8, 2019
@eduardomoroni
Copy link
Member

@gnuns precisa de ajuda para traduzir esta seção? Se quiseres podemos dividir em pedaços menores e pedir ajuda para traduzir :)

@jhonmike
Copy link
Member

@eduardomoroni se precisar posso ajudar na tradução!

@thiagoreis
Copy link

Se for dividir em pedaços menores posso ajudar.

@eduardomoroni
Copy link
Member

Show de bola, vamos esperar um tempo pelo @gnuns e ai a gente ve :)

@glaucia86
Copy link
Member

@gnuns alguma ajuda nessa PR? Se ficar pesado para ti, podemos fazer uma força tarefa para ajudar você na tradução.

cc: @eduardomoroni @WendellAdriel @cezaraugusto o que acham? Se caso ele não responder até domingo, da gente ver com ele novamente se poderá contribuir, caso contrário, atribuir para outras pessoas?

@gnuns
Copy link
Contributor Author

gnuns commented Feb 16, 2019

Opa, galera. Valeu pelo apoio! Fiquei um pouco sem tempo, mas já estou de volta ao trabalho de tradução. Falta bem pouco, acredito que ainda hoje eu subo o que falta, aí qualquer dúvida/problema eu aviso vocês!

@gnuns gnuns changed the title [WIP] Home Page translation [WIP] Translate Home Page Feb 16, 2019
</div>
);
}
}

ReactDOM.render(
<HelloMessage name="Taylor" />,
<HelloMessage name="Daniel" />,
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Só para deixar um nome mais pt-BR, mesmo. :D

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@gnuns

Eu to num impasse em relação à tradução dos exemplos. Entendo sua intenção, mas creio que tinha alguma questão em relação ao sync com o repo original.

Eu acho que se forem só as strings é de boa, mas gostaria de mais opiniões (@glaucia86 @cezaraugusto @eduardomoroni ) ?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hahaha eu gostei da ideia, mas quanto mais o codigo original puder ser mantido, melhor. melhor deixar como o original.

nao ha nenhum impedimento forte para nao mudar mas abre precedente para outras mudancas, por exemplo alguem pode argumentar no futuro que HelloMessage deveria ser traduzido para MensagemDeOi "pra deixar mais pt-BR" e eu nao vou ter um argumento pra negar.

claro, se mudar pra "Cezar" eu deixo :P brincadeira

@gnuns gnuns changed the title [WIP] Translate Home Page Translate Home Page Feb 16, 2019
@gnuns
Copy link
Contributor Author

gnuns commented Feb 16, 2019

Pronto, @glaucia86 @eduardomoroni @halian-vilela!

@halian-vilela halian-vilela added needs review A pull request ready to be reviewed and removed work in progress Author opened the pull-request but it's still being worked on labels Feb 16, 2019
Copy link
Collaborator

@halian-vilela halian-vilela left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Blz @gnuns,

Muito boa tradução cara! Fiz só algumas sugestões.

Após aplicá-las e tirarmos algumas dúvidas com outro revisor, já aprovaremos sua contribuição.

Muito obrigado!

@@ -51,7 +51,7 @@ class Home extends Component {
return (
<Layout location={location}>
<TitleAndMetaTags
title="React &ndash; A JavaScript library for building user interfaces"
title="React &ndash; Uma biblioteca JavaScript para criar user interfaces"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
title="React &ndash; Uma biblioteca JavaScript para criar user interfaces"
title="React &ndash; Uma biblioteca JavaScript para criar interfaces do usuário"

"user interfaces" -> interfaces do usuário?

Não me parece ruim, acha que precisa deixar em inglês?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fiquei em dúvida também e resolvi deixar em inglês. Tava pensando em traduzir como "interfaces de usuário" [1]

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

concordo que "interfaces de usuário" ficaria melhor

@@ -134,7 +134,7 @@ class Home extends Component {
fontSize: 30,
},
}}>
A JavaScript library for building user interfaces
Uma biblioteca JavaScript para criar user interfaces
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
Uma biblioteca JavaScript para criar user interfaces
Uma biblioteca JavaScript para criar interfaces do usuário

Idem acima

src/pages/index.js Outdated Show resolved Hide resolved
src/pages/index.js Outdated Show resolved Hide resolved
content/home/marketing/component-based.md Outdated Show resolved Hide resolved
content/home/examples/a-stateful-component.md Outdated Show resolved Hide resolved
order: 1
domid: timer-example
---

In addition to taking input data (accessed via `this.props`), a component can maintain internal state data (accessed via `this.state`). When a component's state data changes, the rendered markup will be updated by re-invoking `render()`.
Além de receber dados de entrada (acessados via `this.props`), um componente pode manter dados do *state* interno (acessados via `this.state`). Quando os dados do state de um componente são alterados, o código renderizado será atualizado invocando o método `render()` novamente.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ótimo! 👏

content/home/examples/an-application.md Outdated Show resolved Hide resolved
content/home/examples/an-application.md Outdated Show resolved Hide resolved
@halian-vilela halian-vilela added needs +1 Needs another approval before merging needs author response Changes requested needing author's input and removed needs review A pull request ready to be reviewed labels Feb 16, 2019
@glaucia86 glaucia86 removed the needs +1 Needs another approval before merging label Feb 17, 2019
@cezaraugusto
Copy link
Member

@glaucia86 essa PR foi uma das primeiras e ja esta pendente ha algum tempo. que acha da gente aceitar "as-is" e fazer as correcoes em um "follow-up"? o @halian-vilela fez isso em outra PR e eu achei bem legal

@cezaraugusto cezaraugusto added the needs resolution Something not defined that needs maintainers input label Feb 17, 2019
@eduardomoroni
Copy link
Member

Concordo com @cezaraugusto

eduardomoroni
eduardomoroni previously approved these changes Feb 18, 2019
@netlify
Copy link

netlify bot commented Feb 20, 2019

Deploy preview for pt-br-reactjs ready!

Built with commit cd45f88

https://deploy-preview-2--pt-br-reactjs.netlify.com

@cezaraugusto
Copy link
Member

PR migrado para #113. fiz um rebase e mantive os autores dos commits depois de squash

@cezaraugusto cezaraugusto added invalid Something that is outside the scope and removed needs author response Changes requested needing author's input needs resolution Something not defined that needs maintainers input labels Feb 20, 2019
@glaucia86
Copy link
Member

@cezaraugusto aprovei esse PR inerente ao outro PR: #125

Desculpem ausência aqui. Estava resolvendo alguns assuntos pessoais. Mas, aprovado e mergeado :)

brunodahora added a commit to brunodahora/pt-BR.reactjs.org that referenced this pull request Oct 2, 2019
jcserracampos pushed a commit that referenced this pull request Oct 2, 2019
* Update 2019-08-15-new-react-devtools.md

* Apply suggestions from code review

Co-Authored-By: Júlio Campos <[email protected]>

* Apply suggestions from code review #2

Co-Authored-By: Jhon Mike <[email protected]>
react-translations-bot pushed a commit that referenced this pull request Oct 10, 2022
* Added documentation for React.createFactory

* Update beta/src/content/apis/react/createFactory.md

Co-authored-by: Strek <[email protected]>

* minor editorial updates (#2)

* Update createFactory.md

* Update createFactory.md

* edits

Co-authored-by: Strek <[email protected]>
Co-authored-by: Holly Sweeney <[email protected]>
Co-authored-by: Dan Abramov <[email protected]>
rickhanlonii added a commit that referenced this pull request Apr 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
invalid Something that is outside the scope
Projects
None yet
Development

Successfully merging this pull request may close these issues.

9 participants