Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Translating the refs-and-the-dom page #40

Merged
merged 13 commits into from
Feb 17, 2019
Merged

Translating the refs-and-the-dom page #40

merged 13 commits into from
Feb 17, 2019

Conversation

steniowagner
Copy link
Contributor

@steniowagner steniowagner commented Feb 9, 2019 •
edited
Loading

#1

Translating the refs-and-the-dom page to PT-BR.

@fjoshuajr fjoshuajr added the needs review A pull request ready to be reviewed label Feb 9, 2019
cezaraugusto
cezaraugusto requested changes Feb 9, 2019
View reviewed changes
Copy link
Member

@cezaraugusto cezaraugusto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@steniowagner wow bold translation here! I left several comments but most of them are related to the change in the link/anchor sources. I know we used this way before but decided to keep them untranslated so I'm sorry for the incovenience.

content/docs/refs-and-the-dom.md Outdated Show resolved Hide resolved
content/docs/refs-and-the-dom.md Outdated Show resolved Hide resolved
content/docs/refs-and-the-dom.md Outdated Show resolved Hide resolved
content/docs/refs-and-the-dom.md Outdated Show resolved Hide resolved
content/docs/refs-and-the-dom.md Outdated Show resolved Hide resolved
content/docs/refs-and-the-dom.md Outdated Show resolved Hide resolved
content/docs/refs-and-the-dom.md Outdated Show resolved Hide resolved
src/components/CodeEditor/CodeEditor.js Show resolved Hide resolved
src/components/CodeEditor/CodeEditor.js Show resolved Hide resolved
src/components/CodeEditor/CodeEditor.js Show resolved Hide resolved
@cezaraugusto cezaraugusto added needs author response Changes requested needing author's input and removed needs review A pull request ready to be reviewed labels Feb 9, 2019
@steniowagner
Copy link
Contributor Author

Done!

cezaraugusto
cezaraugusto requested changes Feb 9, 2019
View reviewed changes
Copy link
Member

@cezaraugusto cezaraugusto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess you missed some, please change them

content/docs/refs-and-the-dom.md Outdated Show resolved Hide resolved
content/docs/refs-and-the-dom.md Outdated Show resolved Hide resolved
content/docs/refs-and-the-dom.md Outdated Show resolved Hide resolved
@glaucia86
Copy link
Member

@steniowagner

Assim que você concluir as suas mudanças, marque como 'Resolve Conversation' e altere para a label: 'changes already resolved it - translator'.
Muito obrigada pela sua contribuição! 😄

@steniowagner
Copy link
Contributor Author

@glaucia86 how can I change the label?

@WendellAdriel WendellAdriel added feedback addressed and removed needs author response Changes requested needing author's input labels Feb 11, 2019
glaucia86
glaucia86 requested changes Feb 11, 2019
View reviewed changes
Copy link
Member

@glaucia86 glaucia86 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@steniowagner faz as alterações que o @cezaraugusto mencionou a ti (inerente aos códigos)

E capitalize o título do review q te mandei aqui. Assim que fizer essas alterações, estaremos aprovando a sua contribuição. Muito obrigada 😄

content/docs/refs-and-the-dom.md Outdated Show resolved Hide resolved
@glaucia86 glaucia86 added needs author response Changes requested needing author's input and removed feedback addressed labels Feb 11, 2019
@steniowagner
Copy link
Contributor Author

Acho que agora vai, haha!

Me avisem se algo ainda estiver errado!

@eduardomoroni eduardomoroni added feedback addressed and removed needs author response Changes requested needing author's input labels Feb 12, 2019
glaucia86
glaucia86 previously approved these changes Feb 14, 2019
View reviewed changes
Copy link
Member

@glaucia86 glaucia86 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@steniowagner

LGTM 👍
Muito obrigada pela sua contribuição!

cc: @cezaraugusto só aprovar. Mais do que revisado. ;)

@glaucia86 glaucia86 added needs +1 Needs another approval before merging and removed feedback addressed 💪 long page - more than 100 lines Long page labels Feb 14, 2019
halian-vilela
halian-vilela previously requested changes Feb 15, 2019
View reviewed changes
Copy link
Collaborator

@halian-vilela halian-vilela left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bom dia, @steniowagner

Vi que algumas das mudanças na linhas de código solicitadas pelo @cezaraugusto ainda não haviam sido aplicadas.

Adicionei as sugestões aí pois caso o seu editor esteja adicionando-as automaticamente, você consegue commitá-las por aqui.

Também achei alguns pequenos typos que haviam passado batido na revisão anterior.

Fora isso, ótima tradução, só ajustar essas últimas coisinhas aí!

cc: @glaucia86

content/docs/refs-and-the-dom.md Outdated Show resolved Hide resolved
content/docs/refs-and-the-dom.md Outdated Show resolved Hide resolved
content/docs/refs-and-the-dom.md Outdated Show resolved Hide resolved
content/docs/refs-and-the-dom.md Outdated Show resolved Hide resolved
content/docs/refs-and-the-dom.md Outdated Show resolved Hide resolved
content/docs/refs-and-the-dom.md Outdated Show resolved Hide resolved
content/docs/refs-and-the-dom.md Outdated Show resolved Hide resolved
content/docs/refs-and-the-dom.md Outdated Show resolved Hide resolved
@halian-vilela halian-vilela added the needs author response Changes requested needing author's input label Feb 15, 2019
@halian-vilela halian-vilela removed the needs +1 Needs another approval before merging label Feb 15, 2019
@steniowagner steniowagner dismissed stale reviews from glaucia86 via cd12ed8 February 15, 2019 10:59
@steniowagner
Copy link
Contributor Author

@halian-vilela, acabei comitando tudo por aqui mesmo, como você havia proposto. Achei melhor assim por conta da auto-correção do meu editor.

Obrigado!

cezaraugusto
cezaraugusto approved these changes Feb 17, 2019
View reviewed changes
Copy link
Member

@cezaraugusto cezaraugusto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@steniowagner parece otimo, obrigado!

@cezaraugusto
Copy link
Member

visto que foi revisado por 3 pessoas e todas as solicitacoes aprovadas, vou aceitar. obrigado!

@cezaraugusto cezaraugusto merged commit 34d18cc into reactjs:master Feb 17, 2019
@cezaraugusto cezaraugusto added 🌐 translated Translation is completed for this page and removed needs author response Changes requested needing author's input labels Feb 17, 2019
@tesseralis tesseralis mentioned this pull request Feb 17, 2019
Closed
90 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cezaraugusto cezaraugusto cezaraugusto approved these changes

@halian-vilela halian-vilela halian-vilela left review comments

@glaucia86 glaucia86 glaucia86 left review comments

Assignees

@glaucia86 glaucia86

@cezaraugusto cezaraugusto

Labels
🌐 translated Translation is completed for this page
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@steniowagner @glaucia86 @cezaraugusto @halian-vilela @eduardomoroni @WendellAdriel @fjoshuajr