Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

codebase-overview translate #43

Merged
merged 9 commits into from
Feb 11, 2019
Merged

codebase-overview translate #43

merged 9 commits into from
Feb 11, 2019

Conversation

lamecksilva
Copy link
Contributor

No description provided.

@fjoshuajr fjoshuajr added the needs review A pull request ready to be reviewed label Feb 9, 2019
Copy link
Member

@cezaraugusto cezaraugusto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks @lamecksilva! Lots of work here. I left some comments but overall this looks great!

content/docs/codebase-overview.md Outdated Show resolved Hide resolved
content/docs/codebase-overview.md Outdated Show resolved Hide resolved
content/docs/codebase-overview.md Outdated Show resolved Hide resolved
content/docs/codebase-overview.md Outdated Show resolved Hide resolved
content/docs/codebase-overview.md Outdated Show resolved Hide resolved
content/docs/codebase-overview.md Outdated Show resolved Hide resolved
content/docs/codebase-overview.md Outdated Show resolved Hide resolved
content/docs/codebase-overview.md Outdated Show resolved Hide resolved
content/docs/codebase-overview.md Outdated Show resolved Hide resolved
content/docs/codebase-overview.md Outdated Show resolved Hide resolved
@cezaraugusto cezaraugusto added needs author response Changes requested needing author's input and removed needs review A pull request ready to be reviewed labels Feb 9, 2019
@lamecksilva
Copy link
Contributor Author

@cezaraugusto thanks 😉.. i commit again, please check 👍

Copy link
Member

@glaucia86 glaucia86 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@lamecksilva
Algumas alterações a serem feitas. Pedimos que faça os ajustes e logo iremos aprovar a sua contribuição.
Pedimos que, conforme for realizando os acertos que marque como 'Resolve Conversation' e nos sinalize para que possamos analisar novamente a tradução e enfim, aprovar o seu PR. Muito obrigada!

Assim que você concluir as suas mudanças, marque como 'Resolve Conversation' e altere para a label: 'changes already resolved it - translator'.
Muito obrigada pela sua contribuição! 😄

content/docs/codebase-overview.md Outdated Show resolved Hide resolved
content/docs/codebase-overview.md Outdated Show resolved Hide resolved
content/docs/codebase-overview.md Outdated Show resolved Hide resolved
@lamecksilva
Copy link
Contributor Author

@glaucia86 @cezaraugusto

@fjoshuajr fjoshuajr added feedback addressed and removed needs author response Changes requested needing author's input labels Feb 11, 2019
Copy link
Member

@cezaraugusto cezaraugusto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

++

@cezaraugusto cezaraugusto added needs +1 Needs another approval before merging and removed feedback addressed labels Feb 11, 2019
Copy link
Member

@glaucia86 glaucia86 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@lamecksilva

LGTM 👍 Muito obrigada pela sua contribuição! 😄

@glaucia86 glaucia86 merged commit 4a32463 into reactjs:master Feb 11, 2019
@glaucia86 glaucia86 added 🌐 translated Translation is completed for this page and removed needs +1 Needs another approval before merging labels Feb 11, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🌐 translated Translation is completed for this page
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants