Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Translate DOM Elements #45

Merged
merged 35 commits into from
Feb 12, 2019
Merged

Translate DOM Elements #45

merged 35 commits into from
Feb 12, 2019

Conversation

tiagohermano
Copy link
Contributor

No description provided.

@fjoshuajr fjoshuajr added the needs review A pull request ready to be reviewed label Feb 9, 2019
glaucia86
glaucia86 requested changes Feb 10, 2019
View reviewed changes
Copy link
Member

@glaucia86 glaucia86 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@tiagohermano

Algumas alterações a serem feitas. Pedimos que faça os ajustes e logo iremos aprovar a sua contribuição.
Pedimos que, conforme for realizando os acertos que marque como 'Resolve Conversation' e nos sinalize para que possamos analisar novamente a tradução e enfim, aprovar o seu PR. Muito obrigada!

content/docs/reference-dom-elements.md Outdated Show resolved Hide resolved
content/docs/reference-dom-elements.md Outdated Show resolved Hide resolved
content/docs/reference-dom-elements.md Outdated Show resolved Hide resolved
content/docs/reference-dom-elements.md Outdated Show resolved Hide resolved
content/docs/reference-dom-elements.md Outdated Show resolved Hide resolved
content/docs/reference-dom-elements.md Outdated Show resolved Hide resolved
content/docs/reference-dom-elements.md Outdated Show resolved Hide resolved
content/docs/reference-dom-elements.md Outdated Show resolved Hide resolved
content/docs/reference-dom-elements.md Outdated Show resolved Hide resolved
content/docs/reference-dom-elements.md Outdated Show resolved Hide resolved
@glaucia86 glaucia86 added needs author response Changes requested needing author's input and removed needs review A pull request ready to be reviewed labels Feb 10, 2019
glaucia86 and others added 13 commits February 10, 2019 01:40
@glaucia86 @tiagohermano
Update content/docs/reference-dom-elements.md
e24cc48 
Co-Authored-By: tiagohermano <[email protected]>
@glaucia86 @tiagohermano
Update content/docs/reference-dom-elements.md
7cb7822 
Co-Authored-By: tiagohermano <[email protected]>
@glaucia86 @tiagohermano
Update content/docs/reference-dom-elements.md
0f32468 
Co-Authored-By: tiagohermano <[email protected]>
@glaucia86 @tiagohermano
Update content/docs/reference-dom-elements.md
1e42043 
Co-Authored-By: tiagohermano <[email protected]>
@glaucia86 @tiagohermano
Update content/docs/reference-dom-elements.md
89e2820 
Co-Authored-By: tiagohermano <[email protected]>
@glaucia86 @tiagohermano
Update content/docs/reference-dom-elements.md
24f0d08 
Co-Authored-By: tiagohermano <[email protected]>
@glaucia86 @tiagohermano
Update content/docs/reference-dom-elements.md
1d46bf5 
Co-Authored-By: tiagohermano <[email protected]>
@glaucia86 @tiagohermano
Update content/docs/reference-dom-elements.md
d0f3926 
Co-Authored-By: tiagohermano <[email protected]>
@glaucia86 @tiagohermano
Update content/docs/reference-dom-elements.md
7b2391f 
Co-Authored-By: tiagohermano <[email protected]>
@glaucia86 @tiagohermano
Update content/docs/reference-dom-elements.md
effe660 
Co-Authored-By: tiagohermano <[email protected]>
@glaucia86 @tiagohermano
Update content/docs/reference-dom-elements.md
64e368a 
Co-Authored-By: tiagohermano <[email protected]>
@glaucia86 @tiagohermano
Update content/docs/reference-dom-elements.md
ae9f505 
Co-Authored-By: tiagohermano <[email protected]>
@glaucia86 @tiagohermano
Update content/docs/reference-dom-elements.md
9859691 
Co-Authored-By: tiagohermano <[email protected]>
@tiagohermano
Copy link
Contributor Author

Alterações solicitadas realizadas

glaucia86
glaucia86 previously approved these changes Feb 10, 2019
View reviewed changes
Copy link
Member

@glaucia86 glaucia86 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@tiagohermano

LGTM 👍
Queremos agradecer pela sua excelente contribuição! Muito obrigada!

@glaucia86 glaucia86 added needs +1 Needs another approval before merging and removed needs author response Changes requested needing author's input labels Feb 10, 2019
eduardomoroni
eduardomoroni requested changes Feb 10, 2019
View reviewed changes
Copy link
Member

@eduardomoroni eduardomoroni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@tiagofernandez muito obrigado pela ajuda.
Fiz algumas sugestões de alterações, caso tu não concorde com alguma delas estou de boa em aceitar o PR. Não teve nenhum error que venha impactar no resultado final, ao meu ver 👍🏽

content/docs/reference-dom-elements.md Outdated Show resolved Hide resolved
content/docs/reference-dom-elements.md Outdated Show resolved Hide resolved
content/docs/reference-dom-elements.md Outdated Show resolved Hide resolved
content/docs/reference-dom-elements.md Outdated Show resolved Hide resolved
content/docs/reference-dom-elements.md Outdated Show resolved Hide resolved
content/docs/reference-dom-elements.md Outdated Show resolved Hide resolved
content/docs/reference-dom-elements.md Outdated Show resolved Hide resolved
@eduardomoroni eduardomoroni added needs author response Changes requested needing author's input and removed needs +1 Needs another approval before merging labels Feb 10, 2019
@tesseralis tesseralis mentioned this pull request Feb 10, 2019
Closed
90 tasks
@WendellAdriel WendellAdriel added needs +1 Needs another approval before merging feedback addressed and removed needs author response Changes requested needing author's input labels Feb 11, 2019
@glaucia86
Copy link
Member

@tiagohermano chegou a fazer as alterações que o @eduardomoroni propôs aqui?

@tiagohermano
Copy link
Contributor Author

@eduardomoroni Realizei as mudanças que você sugeriu.

eduardomoroni
eduardomoroni previously approved these changes Feb 12, 2019
View reviewed changes
Copy link
Member

@eduardomoroni eduardomoroni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Show de bola mestre, obrigado pela ajuda.

@eduardomoroni eduardomoroni added needs +1 Needs another approval before merging and removed needs author response Changes requested needing author's input labels Feb 12, 2019
fjoshuajr
fjoshuajr requested changes Feb 12, 2019
View reviewed changes
content/docs/reference-dom-elements.md Outdated Show resolved Hide resolved
content/docs/reference-dom-elements.md Outdated Show resolved Hide resolved
content/docs/reference-dom-elements.md Outdated Show resolved Hide resolved
content/docs/reference-dom-elements.md Outdated Show resolved Hide resolved
content/docs/reference-dom-elements.md Outdated Show resolved Hide resolved
content/docs/reference-dom-elements.md Outdated Show resolved Hide resolved
content/docs/reference-dom-elements.md Outdated Show resolved Hide resolved
content/docs/reference-dom-elements.md Outdated Show resolved Hide resolved
content/docs/reference-dom-elements.md Outdated Show resolved Hide resolved
content/docs/reference-dom-elements.md Outdated Show resolved Hide resolved
@fjoshuajr fjoshuajr added needs author response Changes requested needing author's input and removed needs +1 Needs another approval before merging labels Feb 12, 2019
fjoshuajr and others added 9 commits February 12, 2019 20:03
@fjoshuajr @tiagohermano
Update content/docs/reference-dom-elements.md
ccc47fa 
Co-Authored-By: tiagohermano <[email protected]>
@fjoshuajr @tiagohermano
Update content/docs/reference-dom-elements.md
7adf75b 
Co-Authored-By: tiagohermano <[email protected]>
@fjoshuajr @tiagohermano
Update content/docs/reference-dom-elements.md
076ac89 
Co-Authored-By: tiagohermano <[email protected]>
@fjoshuajr @tiagohermano
Update content/docs/reference-dom-elements.md
ee46fff 
Co-Authored-By: tiagohermano <[email protected]>
@fjoshuajr @tiagohermano
Update content/docs/reference-dom-elements.md
d1bd0ee 
Co-Authored-By: tiagohermano <[email protected]>
@fjoshuajr @tiagohermano
Update content/docs/reference-dom-elements.md
ed1339b 
Co-Authored-By: tiagohermano <[email protected]>
@fjoshuajr @tiagohermano
Update content/docs/reference-dom-elements.md
95fff53 
Co-Authored-By: tiagohermano <[email protected]>
@fjoshuajr @tiagohermano
Update content/docs/reference-dom-elements.md
bed5b36 
Co-Authored-By: tiagohermano <[email protected]>
@tiagohermano
Tradução de 'browser' para 'navegador'
98124ed
@tiagohermano
Copy link
Contributor Author

@fjoshuajr sugestões de mudanças atendidas

fjoshuajr
fjoshuajr approved these changes Feb 12, 2019
View reviewed changes
Copy link
Collaborator

@fjoshuajr fjoshuajr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🎉🎉

@fjoshuajr fjoshuajr added 🌐 translated Translation is completed for this page and removed needs author response Changes requested needing author's input labels Feb 12, 2019
@fjoshuajr
Copy link
Collaborator

Show de bola mestre, obrigado pela ajuda.

Vou fazer merge 🚀🚀

@fjoshuajr fjoshuajr merged commit 3dbb42c into reactjs:master Feb 12, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fjoshuajr fjoshuajr fjoshuajr approved these changes

@eduardomoroni eduardomoroni eduardomoroni left review comments

@glaucia86 glaucia86 glaucia86 left review comments

Assignees
No one assigned
Labels
🌐 translated Translation is completed for this page
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@tiagohermano @glaucia86 @fjoshuajr @eduardomoroni @WendellAdriel