Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Translate Hello World #57

Merged
merged 11 commits into from
Feb 12, 2019
Merged

Translate Hello World #57

merged 11 commits into from
Feb 12, 2019

Conversation

rafael-vitor
Copy link
Contributor

#1

@fjoshuajr fjoshuajr added the needs review A pull request ready to be reviewed label Feb 10, 2019
tibuurcio
tibuurcio requested changes Feb 10, 2019
View reviewed changes
Copy link
Collaborator

@tibuurcio tibuurcio left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @rafael-vitor, thanks for taking the time to help with translation. The hello-world page is such an important one!

I've made some reviews mostly based on syntax. Also, we shouldn't translate anchor links as per the universal styleguide.

Please let me know if you think anything should be different. Cheers 😄

content/docs/hello-world.md Outdated Show resolved Hide resolved
content/docs/hello-world.md Outdated Show resolved Hide resolved
content/docs/hello-world.md Outdated Show resolved Hide resolved
content/docs/hello-world.md Outdated Show resolved Hide resolved
content/docs/hello-world.md Outdated Show resolved Hide resolved
content/docs/hello-world.md Outdated Show resolved Hide resolved
content/docs/hello-world.md Outdated Show resolved Hide resolved
@tibuurcio tibuurcio added the needs author response Changes requested needing author's input label Feb 10, 2019
glaucia86
glaucia86 requested changes Feb 10, 2019
View reviewed changes
Copy link
Member

@glaucia86 glaucia86 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@rafael-vitor

Algumas alterações a serem feitas. Pedimos que faça os ajustes e logo iremos aprovar a sua contribuição.
Pedimos que, conforme for realizando os acertos que marque como 'Resolve Conversation' e nos sinalize para que possamos analisar novamente a tradução e enfim, aprovar o seu PR. Muito obrigada!

content/docs/hello-world.md Outdated Show resolved Hide resolved
content/docs/hello-world.md Outdated Show resolved Hide resolved
content/docs/hello-world.md Outdated Show resolved Hide resolved
content/docs/hello-world.md Outdated Show resolved Hide resolved
content/docs/hello-world.md Outdated Show resolved Hide resolved
@glaucia86 glaucia86 removed the needs review A pull request ready to be reviewed label Feb 10, 2019
@glaucia86
Copy link
Member

@rafael-vitor

Algumas alterações a serem feitas. Pedimos que faça os ajustes e logo iremos aprovar a sua contribuição.
Pedimos que, conforme for realizando os acertos que marque como 'Resolve Conversation' e nos sinalize para que possamos analisar novamente a tradução e enfim, aprovar o seu PR. Muito obrigada!

Assim que você concluir as suas mudanças, marque como 'Resolve Conversation' e altere para a label: 'changes already resolved it - translator'.
Muito obrigada pela sua contribuição! 😄

tibuurcio and others added 10 commits February 10, 2019 11:30
@tibuurcio @rafael-vitor
Update content/docs/hello-world.md
2cbc076 
Co-Authored-By: rafael-vitor <[email protected]>
@tibuurcio @rafael-vitor
Update content/docs/hello-world.md
c23fe78 
Co-Authored-By: rafael-vitor <[email protected]>
@tibuurcio @rafael-vitor
Update content/docs/hello-world.md
be484a1 
Co-Authored-By: rafael-vitor <[email protected]>
@tibuurcio @rafael-vitor
Update content/docs/hello-world.md
43bd21c 
Co-Authored-By: rafael-vitor <[email protected]>
@tibuurcio @rafael-vitor
Update content/docs/hello-world.md
2b44323 
Co-Authored-By: rafael-vitor <[email protected]>
@glaucia86 @rafael-vitor
Update content/docs/hello-world.md
d2e6408 
Co-Authored-By: rafael-vitor <[email protected]>
@glaucia86 @rafael-vitor
Update content/docs/hello-world.md
c97691a 
Co-Authored-By: rafael-vitor <[email protected]>
@glaucia86 @rafael-vitor
Apply suggestions from code review
57afdd4 
Co-Authored-By: rafael-vitor <[email protected]>
@rafael-vitor
FIx duplicated line
cadb27f
@rafael-vitor
Add missing >
297eaf9
@rafael-vitor
Copy link
Contributor Author

Olá @glaucia86

As alterações solicitadas foram realizadas.

@tesseralis tesseralis mentioned this pull request Feb 10, 2019
Closed
90 tasks
@rafael-vitor
Copy link
Contributor Author

@glaucia86 Acho que não posso alterar a label por que não sou contribuidor 😬

@tibuurcio tibuurcio added feedback addressed and removed needs author response Changes requested needing author's input labels Feb 11, 2019
glaucia86
glaucia86 approved these changes Feb 12, 2019
View reviewed changes
Copy link
Member

@glaucia86 glaucia86 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@rafael-vitor
LGTM 👍
Queremos agradecer pela sua excelente contribuição! Muito obrigada!

@glaucia86 glaucia86 merged commit 1cafa29 into reactjs:master Feb 12, 2019
@glaucia86 glaucia86 added 🌐 translated Translation is completed for this page and removed feedback addressed labels Feb 12, 2019
@rafael-vitor rafael-vitor deleted the hello-world branch February 12, 2019 10:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@glaucia86 glaucia86 glaucia86 approved these changes

@tibuurcio tibuurcio tibuurcio approved these changes

Assignees
No one assigned
Labels
🌐 translated Translation is completed for this page
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@rafael-vitor @glaucia86 @tibuurcio @fjoshuajr