Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix some link translations in initial PR's #58

Merged
merged 4 commits into from
Feb 10, 2019
Merged

Fix some link translations in initial PR's #58

merged 4 commits into from
Feb 10, 2019

Conversation

tibuurcio
Copy link
Collaborator

As per #42, fixed some links in some of the initial PR's. Daunting task but using IntelliJ VCS history helped a bit. I believe most of the PR's in the list are covered, but may need another look through the list.

Added PR's ID in commit messages to make it easy to identify changes.

@fjoshuajr fjoshuajr added the needs review A pull request ready to be reviewed label Feb 10, 2019
Copy link
Member

@glaucia86 glaucia86 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@glaucia86 glaucia86 added needs +1 Needs another approval before merging and removed needs review A pull request ready to be reviewed labels Feb 10, 2019
Copy link
Collaborator

@fjoshuajr fjoshuajr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good to go! 🎉

@fjoshuajr fjoshuajr added follow-up Changes applied in a previously translated file and removed needs +1 Needs another approval before merging labels Feb 10, 2019
@fjoshuajr fjoshuajr merged commit 74fca93 into reactjs:master Feb 10, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
follow-up Changes applied in a previously translated file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants