Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Translate Integrating With Other Libraries #82

Merged
merged 25 commits into from
Feb 15, 2019
Merged

Translate Integrating With Other Libraries #82

merged 25 commits into from
Feb 15, 2019

Conversation

thulioph
Copy link
Contributor

#1

@fjoshuajr fjoshuajr added the needs review A pull request ready to be reviewed label Feb 11, 2019
glaucia86
glaucia86 requested changes Feb 12, 2019
View reviewed changes
Copy link
Member

@glaucia86 glaucia86 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@thulioph poucas mudanças para fazer... basta fazer as mudanças.

content/docs/integrating-with-other-libraries.md Outdated Show resolved Hide resolved
content/docs/integrating-with-other-libraries.md Outdated Show resolved Hide resolved
@glaucia86 glaucia86 added the needs author response Changes requested needing author's input label Feb 12, 2019
@eduardomoroni eduardomoroni added needs +1 Needs another approval before merging and removed needs review A pull request ready to be reviewed labels Feb 12, 2019
@thulioph
Copy link
Contributor Author

Obrigado pelo feedback @glaucia86.

@cezaraugusto cezaraugusto added feedback addressed and removed needs +1 Needs another approval before merging needs author response Changes requested needing author's input labels Feb 13, 2019
fjoshuajr
fjoshuajr requested changes Feb 13, 2019
View reviewed changes
Copy link
Collaborator

@fjoshuajr fjoshuajr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Estamos quase lá @thulioph

content/docs/integrating-with-other-libraries.md Outdated Show resolved Hide resolved
content/docs/integrating-with-other-libraries.md Outdated Show resolved Hide resolved
content/docs/integrating-with-other-libraries.md Outdated Show resolved Hide resolved
content/docs/integrating-with-other-libraries.md Outdated Show resolved Hide resolved
content/docs/integrating-with-other-libraries.md Outdated Show resolved Hide resolved
content/docs/integrating-with-other-libraries.md Outdated Show resolved Hide resolved
content/docs/integrating-with-other-libraries.md Outdated Show resolved Hide resolved
content/docs/integrating-with-other-libraries.md Outdated Show resolved Hide resolved
content/docs/integrating-with-other-libraries.md Outdated Show resolved Hide resolved
@fjoshuajr fjoshuajr added needs author response Changes requested needing author's input and removed feedback addressed labels Feb 13, 2019
fjoshuajr and others added 9 commits February 13, 2019 12:26
@fjoshuajr @thulioph
Update content/docs/integrating-with-other-libraries.md
4332936 
Adding more context to the sentence.

Co-Authored-By: thulioph <[email protected]>
@fjoshuajr @thulioph
Update content/docs/integrating-with-other-libraries.md
c059031 
Updates the word with an italic markup.

Co-Authored-By: thulioph <[email protected]>
@fjoshuajr @thulioph
Update content/docs/integrating-with-other-libraries.md
cd31c54 
Updates the word with an italic markup and the English version.

Co-Authored-By: thulioph <[email protected]>
@fjoshuajr @thulioph
Update content/docs/integrating-with-other-libraries.md
fb68431 
Adding a contextual translation that makes more sense.

Co-Authored-By: thulioph <[email protected]>
@fjoshuajr @thulioph
Update content/docs/integrating-with-other-libraries.md
67c6040 
Updates the word genre.

Co-Authored-By: thulioph <[email protected]>
@fjoshuajr @thulioph
Update content/docs/integrating-with-other-libraries.md
d2ca766 
Updates the English keyword to be italic.

Co-Authored-By: thulioph <[email protected]>
@fjoshuajr @thulioph
Update content/docs/integrating-with-other-libraries.md
4d372cd 
Updates the translation by adding the English version of the keyword.

Co-Authored-By: thulioph <[email protected]>
@fjoshuajr @thulioph
Update content/docs/integrating-with-other-libraries.md
c304af3 
Using a different synonym that makes more sense.

Co-Authored-By: thulioph <[email protected]>
@fjoshuajr @thulioph
Update content/docs/integrating-with-other-libraries.md
058549d 
Translates the word to Portuguese and adds the English version.

Co-Authored-By: thulioph <[email protected]>
@thulioph
Copy link
Contributor Author

Obrigado pela atenção @fjoshuajr, tudo corrigido.

fjoshuajr
fjoshuajr previously approved these changes Feb 13, 2019
View reviewed changes
Copy link
Collaborator

@fjoshuajr fjoshuajr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👌

@fjoshuajr fjoshuajr added the needs +1 Needs another approval before merging label Feb 13, 2019
@fjoshuajr fjoshuajr added 💪 long page - more than 100 lines Long page and removed needs author response Changes requested needing author's input labels Feb 13, 2019
gabrielbs
gabrielbs suggested changes Feb 14, 2019
View reviewed changes
content/docs/integrating-with-other-libraries.md Show resolved Hide resolved
content/docs/integrating-with-other-libraries.md Outdated Show resolved Hide resolved
content/docs/integrating-with-other-libraries.md Outdated Show resolved Hide resolved
content/docs/integrating-with-other-libraries.md Outdated Show resolved Hide resolved
content/docs/integrating-with-other-libraries.md Outdated Show resolved Hide resolved
content/docs/integrating-with-other-libraries.md Outdated Show resolved Hide resolved
content/docs/integrating-with-other-libraries.md Show resolved Hide resolved
content/docs/integrating-with-other-libraries.md Outdated Show resolved Hide resolved
content/docs/integrating-with-other-libraries.md Outdated Show resolved Hide resolved
content/docs/integrating-with-other-libraries.md Outdated Show resolved Hide resolved
@gabrielbs @thulioph
Update content/docs/integrating-with-other-libraries.md
93e7439 
Adds a different word for the Portuguese version to keep the pattern.

Co-Authored-By: thulioph <[email protected]>
@thulioph thulioph dismissed stale reviews from fjoshuajr via 93e7439 February 14, 2019 20:36
gabrielbs and others added 9 commits February 14, 2019 17:37
@gabrielbs @thulioph
Update content/docs/integrating-with-other-libraries.md
7c18c58 
Adds a different word for the Portuguese version to keep the pattern.

Co-Authored-By: thulioph <[email protected]>
@gabrielbs @thulioph
Update content/docs/integrating-with-other-libraries.md
38f215e 
Translate to Portuguese.

Co-Authored-By: thulioph <[email protected]>
@gabrielbs @thulioph
Update content/docs/integrating-with-other-libraries.md
67a9141 
Translate to Portuguese.

Co-Authored-By: thulioph <[email protected]>
@gabrielbs @thulioph
Update content/docs/integrating-with-other-libraries.md
9f19433 
Translate to Portuguese.

Co-Authored-By: thulioph <[email protected]>
@gabrielbs @thulioph
Update content/docs/integrating-with-other-libraries.md
1515ffa 
Translate to Portuguese.

Co-Authored-By: thulioph <[email protected]>
@gabrielbs @thulioph
Update content/docs/integrating-with-other-libraries.md
abd63c3 
Translate to Portuguese.

Co-Authored-By: thulioph <[email protected]>
@gabrielbs @thulioph
Update content/docs/integrating-with-other-libraries.md
69934cd 
Translate to Portuguese.

Co-Authored-By: thulioph <[email protected]>
@gabrielbs @thulioph
Update content/docs/integrating-with-other-libraries.md
a1a3b4e 
Translate to Portuguese.

Co-Authored-By: thulioph <[email protected]>
@gabrielbs @thulioph
Update content/docs/integrating-with-other-libraries.md
98b9071 
Translate to Portuguese.

Co-Authored-By: thulioph <[email protected]>
glaucia86
glaucia86 approved these changes Feb 14, 2019
View reviewed changes
Copy link
Member

@glaucia86 glaucia86 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@thulioph
LGTM 👍

gabrielbs
gabrielbs approved these changes Feb 15, 2019
View reviewed changes
Copy link
Contributor

@gabrielbs gabrielbs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Aprovado, ficou ótimo! Parabéns

fjoshuajr
fjoshuajr approved these changes Feb 15, 2019
View reviewed changes
Copy link
Collaborator

@fjoshuajr fjoshuajr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉✨

@fjoshuajr fjoshuajr added 🌐 translated Translation is completed for this page and removed needs +1 Needs another approval before merging 💪 long page - more than 100 lines Long page labels Feb 15, 2019
@fjoshuajr fjoshuajr merged commit 6a047e2 into reactjs:master Feb 15, 2019
@tesseralis tesseralis mentioned this pull request Feb 15, 2019
Closed
90 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@glaucia86 glaucia86 glaucia86 approved these changes

@gabrielbs gabrielbs gabrielbs approved these changes

@fjoshuajr fjoshuajr fjoshuajr approved these changes

Assignees

@glaucia86 glaucia86

@fjoshuajr fjoshuajr

Labels
🌐 translated Translation is completed for this page
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@thulioph @glaucia86 @gabrielbs @fjoshuajr @eduardomoroni @cezaraugusto